Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Agentless Workload Scanning [SSPROD-37035] #53

Merged
merged 3 commits into from
Mar 12, 2024
Merged

feat: Agentless Workload Scanning [SSPROD-37035] #53

merged 3 commits into from
Mar 12, 2024

Conversation

mms2409
Copy link
Contributor

@mms2409 mms2409 commented Feb 15, 2024

https://sysdig.atlassian.net/browse/SSPROD-37035

  • Workload Scanning initial commit

@mms2409 mms2409 self-assigned this Feb 15, 2024
@mms2409 mms2409 requested a review from a team as a code owner February 15, 2024 20:14
@mms2409 mms2409 changed the title feat: workload scanning initial commit [SSPROD-37035] feat: Agentless Workload Scanning [SSPROD-37035] Feb 15, 2024
@mms2409 mms2409 force-pushed the feat/workload-scanning branch from 7de2cc8 to 706d2e2 Compare February 15, 2024 20:18
alexeyovriakh
alexeyovriakh previously approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@alexeyovriakh alexeyovriakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some questions and nits but this is good @mms2409 👍

test/examples/secure_workload_scanning/single/main.tf.OFF Outdated Show resolved Hide resolved
test/examples/secure_workload_scanning/single/main.tf.OFF Outdated Show resolved Hide resolved
modules/services/workload-scanning/variables.tf Outdated Show resolved Hide resolved
modules/services/workload-scanning/organizational.tf Outdated Show resolved Hide resolved
modules/services/workload-scanning/main.tf Outdated Show resolved Hide resolved
modules/services/workload-scanning/variables.tf Show resolved Hide resolved
modules/services/workload-scanning/main.tf Show resolved Hide resolved
@mms2409 mms2409 force-pushed the feat/workload-scanning branch from 707278f to 1b78b95 Compare March 12, 2024 12:41
@mms2409 mms2409 requested a review from a team as a code owner March 12, 2024 12:41
@mms2409 mms2409 requested a review from alexeyovriakh March 12, 2024 12:41
@mms2409 mms2409 force-pushed the feat/workload-scanning branch from ed901f4 to ebcb46e Compare March 12, 2024 12:44
@mms2409 mms2409 force-pushed the feat/workload-scanning branch from ebcb46e to 05bddae Compare March 12, 2024 12:46
alexeyovriakh
alexeyovriakh approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@alexeyovriakh alexeyovriakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @mms2409! 👏

@mms2409 mms2409 merged commit e0d76e7 into main Mar 12, 2024
5 checks passed
@mms2409 mms2409 deleted the feat/workload-scanning branch March 12, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acaprari acaprari acaprari left review comments

@alexeyovriakh alexeyovriakh alexeyovriakh approved these changes

Assignees

@mms2409 mms2409

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mms2409 @acaprari @alexeyovriakh