Avoid calling Unref on a closed port

Fixes justinlatimer#21
drewish · Apr 6, 2014 · 12ccdd2 · 12ccdd2
1 parent 78548c3
commit 12ccdd2
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/src/node-midi.cpp b/src/node-midi.cpp
@@ -304,12 +304,14 @@ class NodeMidiInput : public ObjectWrap
         input->in->openVirtualPort(name);
         return scope.Close(v8::Undefined());
     }
-    
+
     static v8::Handle<v8::Value> ClosePort(const v8::Arguments& args)
     {
         v8::HandleScope scope;
         NodeMidiInput* input = ObjectWrap::Unwrap<NodeMidiInput>(args.This());
-        input->Unref();
+        if (input->in->isPortOpen()) {
+            input->Unref();
+        }
         input->in->closePort();
         uv_close((uv_handle_t*)&input->message_async, NULL);
         return scope.Close(v8::Undefined());

diff --git a/test/unit-tests.js b/test/unit-tests.js
@@ -41,6 +41,14 @@ describe('midi.input', function() {
       input.getPortName(999).should.eql('');
     });
   });
+
+  describe('.closePort', function() {
+    var input = new Midi.input();
+
+    it('allows you to close a port that was not opened', function() {
+      input.closePort();
+    });
+  });
 });
 
 describe('midi.output', function() {
@@ -82,4 +90,12 @@ describe('midi.output', function() {
       output.getPortName(999).should.eql('');
     });
   });
+
+  describe('.closePort', function() {
+    var output = new Midi.output();
+
+    it('allows you to close a port that was not opened', function() {
+      output.closePort();
+    });
+  });
 });