Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Arbitrum Chain to CoW Protocol #6038

Merged
merged 11 commits into from
Jun 3, 2024

Conversation

olgafetisova
Copy link
Contributor

Contribution type

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

For new spell(s)

  • Spell name(s): cow_protocol_arbitrum.trades

  • Description: The spell adds all CoW Protocol settled trades on Arbitrum chain. The spell is designed for the entire community and the data will be included to the dex_aggregator.trades community table.

  • Test instructions: P
    OC query can be found here https://dune.com/queries/3783635


For adding to existing spell lineage

  • Description: Adding new union to the existing spell with Arbitrum chain to the cow_protocol.trades. The table is CoW Protocol trades on all chains across all contracts and versions. This table loads dex trades downstream.

Adding cow protocol arbitrum trades
Adding YML file for Arbitrum chain
Adding Arbitrum chain to the table
@dune-eng
Copy link

Workflow run id 9308684703 approved.

@dune-eng
Copy link

Workflow run id 9308684794 approved.

Adding Arbitrum schema to the projects
@dune-eng
Copy link

Workflow run id 9318422113 approved.

@dune-eng
Copy link

Workflow run id 9318422220 approved.

Adding new sources for arbitrum cow protocol
@dune-eng
Copy link

Workflow run id 9318529721 approved.

@dune-eng
Copy link

Workflow run id 9318529904 approved.

Changing gnosis to arbitrum
@dune-eng
Copy link

Workflow run id 9319024549 approved.

@dune-eng
Copy link

Workflow run id 9319024831 approved.

@dune-eng
Copy link

Workflow run id 9319321870 approved.

@dune-eng
Copy link

Workflow run id 9319322022 approved.

@olgafetisova
Copy link
Contributor Author

@jeff-dude would appreciate a review

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor tweaks below

dbt_project.yml Outdated
Comment on lines 677 to 678
arbitrum:
+schema: cow_protocol_arbitrum
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we no longer needs edit to this file, we're working through cleaning out all schemas from here and applying directly in models instead for easier readability. plz do remove here 🙏

@@ -0,0 +1,225 @@
{{ config(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the above comment on schemas, plz add here instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, adjusted

@jeff-dude jeff-dude self-assigned this May 31, 2024
@jeff-dude jeff-dude added WIP work in progress in review Assignee is currently reviewing the PR labels May 31, 2024
Removing unnecessary logic
@dune-eng
Copy link

dune-eng commented Jun 3, 2024

Workflow run id 9347928527 approved.

@dune-eng
Copy link

dune-eng commented Jun 3, 2024

Workflow run id 9347928448 approved.

Adding schema directly to cow_protocol_arbitrum_trades.sql to avoid complexity
@dune-eng
Copy link

dune-eng commented Jun 3, 2024

Workflow run id 9348040331 approved.

@dune-eng
Copy link

dune-eng commented Jun 3, 2024

Workflow run id 9348040546 approved.

@jeff-dude jeff-dude added ready-for-merging and removed WIP work in progress in review Assignee is currently reviewing the PR labels Jun 3, 2024
@dune-eng
Copy link

dune-eng commented Jun 3, 2024

Workflow run id 9350463151 approved.

@dune-eng
Copy link

dune-eng commented Jun 3, 2024

Workflow run id 9350462953 approved.

@jeff-dude jeff-dude merged commit f231f71 into duneanalytics:main Jun 3, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants