-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Arbitrum Chain to CoW Protocol #6038
Conversation
Adding cow protocol arbitrum trades
adjusting name
Adding YML file for Arbitrum chain
Adding Arbitrum chain to the table
Workflow run id 9308684703 approved. |
Workflow run id 9308684794 approved. |
Adding Arbitrum schema to the projects
Workflow run id 9318422113 approved. |
Workflow run id 9318422220 approved. |
Adding new sources for arbitrum cow protocol
Workflow run id 9318529721 approved. |
Workflow run id 9318529904 approved. |
Changing gnosis to arbitrum
Workflow run id 9319024549 approved. |
Workflow run id 9319024831 approved. |
Fixing syntax
Workflow run id 9319321870 approved. |
Workflow run id 9319322022 approved. |
@jeff-dude would appreciate a review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor tweaks below
dbt_project.yml
Outdated
arbitrum: | ||
+schema: cow_protocol_arbitrum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we no longer needs edit to this file, we're working through cleaning out all schemas from here and applying directly in models instead for easier readability. plz do remove here 🙏
@@ -0,0 +1,225 @@ | |||
{{ config( | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the above comment on schemas, plz add here instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, adjusted
Removing unnecessary logic
Workflow run id 9347928527 approved. |
Workflow run id 9347928448 approved. |
Adding schema directly to cow_protocol_arbitrum_trades.sql to avoid complexity
Workflow run id 9348040331 approved. |
Workflow run id 9348040546 approved. |
Workflow run id 9350463151 approved. |
Workflow run id 9350462953 approved. |
Contribution type
For new spell(s)
Spell name(s): cow_protocol_arbitrum.trades
Description: The spell adds all CoW Protocol settled trades on Arbitrum chain. The spell is designed for the entire community and the data will be included to the dex_aggregator.trades community table.
Test instructions: P
OC query can be found here https://dune.com/queries/3783635
For adding to existing spell lineage