-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ethereum/Optimism/Polygon Safe Balance V2 #6662
Conversation
Made changes because previous version doesn't properly capture the balances for the safe
Workflow run id 10698146611 approved. |
Workflow run id 10698146797 approved. |
Hi @safeintern, I will be working on an incrementally enabled macro to materialize balance in this PR today. |
Workflow run id 10699032046 approved. |
Workflow run id 10699032739 approved. |
Workflow run id 10699076657 approved. |
Workflow run id 10699076969 approved. |
thanks! curious if my approach now works but if your solution is more efficient, great! |
@0xRobin is there any update on this? |
Yes, we've got the new macro to materialize balances merged, I'll test that out today in this PR |
Performance is worrisome here, I will revert my commits and we can seek to merge your changes. |
@jeff-dude CI is expected to timeout here, but we should be good to merge. |
Due to MATIC --> POL migration, had changed to POL
Workflow run id 10826243972 approved. |
Workflow run id 10826244393 approved. |
Made changes because previous version doesn't properly capture the balances for the safe
Thank you for contributing to Spellbook 🪄
Update!
Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.
Contribution type
Please check the type of contribution this pull request is for:
Note: You can safely discard any section below which doesn't apply based on selection above
For new spell(s)
If you are building new spell(s), please provide the following information:
For adding to existing spell lineage
If you are adding to an existing spell lineage, please provide the following information:
For bug fixes
If you are fixing a bug, please provide the following information:
Additional information
Please provide any additional information that might help us review your pull request:
Thank you for your contribution!