Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ethereum/Optimism/Polygon Safe Balance V2 #6662

Merged
merged 6 commits into from
Sep 16, 2024

Conversation

safeintern
Copy link
Contributor

Made changes because previous version doesn't properly capture the balances for the safe

Thank you for contributing to Spellbook 🪄

Update!

Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


For new spell(s)

If you are building new spell(s), please provide the following information:

  • Spell name(s): schema.table_name
  • Description: [Detailed description of the new spell(s) and their purpose]
  • Who are the new spell(s) for? [Internal team or general community]
  • How will the new spell(s) be used downstream? [Description of downstream usage]
  • Implementation details: [Information on how the spell(s) are implemented]
  • Test instructions: [How to test the new spell(s)]
  • Related issue(s): [Link to related issues, if any]

For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

  • Description: [Description of the changes made]

For bug fixes

If you are fixing a bug, please provide the following information:

  • Description: [Description of the bug fix]
  • Steps to reproduce: [How to reproduce the bug]
  • Implementation details: [Information on how the bug was fixed]
  • Test instructions: [How to test the fix]
  • Related issue(s): [Link to related issues, if any]

Additional information

Please provide any additional information that might help us review your pull request:

  • [Any additional information]

Thank you for your contribution!

Made changes because previous version doesn't properly capture the balances for the safe
@dune-eng
Copy link

dune-eng commented Sep 4, 2024

Workflow run id 10698146611 approved.

@dune-eng
Copy link

dune-eng commented Sep 4, 2024

Workflow run id 10698146797 approved.

@0xRobin
Copy link
Collaborator

0xRobin commented Sep 4, 2024

Hi @safeintern, I will be working on an incrementally enabled macro to materialize balance in this PR today.
The goal is that it will be directly applicable for Safe as well and should resolve the incremental problems you were seeing.

@0xRobin 0xRobin self-assigned this Sep 4, 2024
@dune-eng
Copy link

dune-eng commented Sep 4, 2024

Workflow run id 10699032046 approved.

@dune-eng
Copy link

dune-eng commented Sep 4, 2024

Workflow run id 10699032739 approved.

@dune-eng
Copy link

dune-eng commented Sep 4, 2024

Workflow run id 10699076657 approved.

@dune-eng
Copy link

dune-eng commented Sep 4, 2024

Workflow run id 10699076969 approved.

@safeintern safeintern changed the title Update Ethereum Safe Balance V2 Update Ethereum/Optimism/Polygon Safe Balance V2 Sep 4, 2024
@safeintern
Copy link
Contributor Author

Hi @safeintern, I will be working on an incrementally enabled macro to materialize balance in this PR today. The goal is that it will be directly applicable for Safe as well and should resolve the incremental problems you were seeing.

thanks! curious if my approach now works but if your solution is more efficient, great!

@jeff-dude jeff-dude added WIP work in progress in review Assignee is currently reviewing the PR labels Sep 4, 2024
@safeintern
Copy link
Contributor Author

@0xRobin is there any update on this?

@0xRobin
Copy link
Collaborator

0xRobin commented Sep 10, 2024

Yes, we've got the new macro to materialize balances merged, I'll test that out today in this PR

@0xRobin
Copy link
Collaborator

0xRobin commented Sep 11, 2024

Performance is worrisome here, I will revert my commits and we can seek to merge your changes.
I'll have to experiment more but don't want to block your progress as well.

@0xRobin 0xRobin added ready-for-merging and removed WIP work in progress in review Assignee is currently reviewing the PR labels Sep 11, 2024
@0xRobin
Copy link
Collaborator

0xRobin commented Sep 11, 2024

@jeff-dude CI is expected to timeout here, but we should be good to merge.

Due to MATIC --> POL migration, had changed to POL
@dune-eng
Copy link

Workflow run id 10826243972 approved.

@dune-eng
Copy link

Workflow run id 10826244393 approved.

@jeff-dude jeff-dude merged commit 0c673f2 into duneanalytics:main Sep 16, 2024
1 of 2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants