Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prices_bnb_tokens.sql #7149

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Update prices_bnb_tokens.sql #7149

merged 2 commits into from
Nov 18, 2024

Conversation

monidob
Copy link
Contributor

@monidob monidob commented Nov 18, 2024

Atlas token (0x83850d97018f665eb746fbb8f18351e977d1b0d6) added to the price table.

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

[...]


quick links for more information:

Atlas token (0x83850d97018f665eb746fbb8f18351e977d1b0d6) added to the price table.
@monidob
Copy link
Contributor Author

monidob commented Nov 18, 2024

Link to CoinPaprica: https://coinpaprika.com/coin/atlas-star-atlas/

@@ -290,7 +290,8 @@ FROM
('ice-ice-network', 'bnb', 'ICE', 0xc335df7c25b72eec661d5aa32a7c2b7b2a1d1874, 18),
('jmpt-jumptoken', 'bnb', 'JMPT', 0x88d7e9b65dc24cf54f5edef929225fc3e1580c25, 18),
('usdfi-usdfi', 'bnb', 'USDFI', 0x7df1938170869afe410098540c051a8a50308988, 18),
('wncg-wrapped-ncg', 'bnb', 'WNCG', 0x52242cbAb41e290E9E17CCC50Cc437bB60020a9d, 18)
('wncg-wrapped-ncg', 'bnb', 'WNCG', 0x52242cbAb41e290E9E17CCC50Cc437bB60020a9d, 18),
('atlas-star-atlas-wormhole', 'bnb', 'ATLAS', 0x83850d97018f665eb746fbb8f18351e977d1b0d6, 8)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the API token_id value didn't match URL value. i copied from the API key section in that linked coinpaprika page and pasted here. this should work

@jeff-dude jeff-dude self-assigned this Nov 18, 2024
@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR dbt: tokens covers the Tokens dbt subproject labels Nov 18, 2024
@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Nov 18, 2024
@jeff-dude jeff-dude merged commit 5225455 into duneanalytics:main Nov 18, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: tokens covers the Tokens dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants