Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct SQL Operator and Typographical Issues #7382

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Correct SQL Operator and Typographical Issues #7382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Contributions in the form of issues and pull requests are very much welcome here

## [BETA] Pre-push hooks

UPDATE: These pre-push hooks require running `dbt compile` which is a fairly slow step due to the size of our project. We intend to rewrite these hooks to be more efficient but for the time being they remain cumbersome. Feel free to use them if you find them useful but the same checks will run in a Github Action when you commit your code. Feel free to uninstall if they do not bring joy, we'll let wizards know when we think we've improved them enought to warrant making them part of the general development flow.
UPDATE: These pre-push hooks require running `dbt compile` which is a fairly slow step due to the size of our project. We intend to rewrite these hooks to be more efficient but for the time being they remain cumbersome. Feel free to use them if you find them useful but the same checks will run in a Github Action when you commit your code. Feel free to uninstall if they do not bring joy, we'll let wizards know when we think we've improved them enough to warrant making them part of the general development flow.

We are testing out adding pre-push hooks to our workflow. The goal is to catch common errors before code is pushed and
streamline the pull request review process.
Expand Down Expand Up @@ -126,13 +126,13 @@ example custom test:
```sql
with unit_test1 as
(select
case when col1 == 2 and col2 == 'moon' then True else False end as test
case when col1 = 2 and col2 = 'moon' then True else False end as test
from {{ ref('mock_table' )}}
where tx_id = '102'),

unit_test2 as
(select
case when col1 == 2 and col2 == 'moon' then True else False end as test
case when col1 = 2 and col2 = 'moon' then True else False end as test
from {{ ref('mock_table' )}}
where tx_id = '103'),

Expand Down
Loading