Curve code added #7386
Draft
Curve code added #7386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
WIP
github-actions
bot
added
ready-for-review
Hosuke
approved these changes
Dec 26, 2024
0xRobin
requested changes
Dec 29, 2024
| @@ -13,6 +13,7 @@ FROM (VALUES | |||
| ('uniswap', 'Uniswap', 'Direct', 'Uniswap') | |||
| , ('pancakeswap', 'PancakeSwap', 'Direct', 'PancakeSwap') | |||
| , ('curve', 'Curve', 'Direct', 'CurveFinance') | |||
| , ('curvefi', 'Curve', 'Direct', 'CurveFinance') | |||
There was a problem hiding this comment.
we've been using curve as the name for Curve Finance (See row above)
|
|
||
| SELECT | ||
| 'base' AS blockchain, | ||
| 'curvefi' AS project, |
There was a problem hiding this comment.
'curve' instead of 'curvefi'
Comment on lines
+24
to
+29
| FROM | ||
| {{ source('curvefi_base', 'StableSwap_evt_TokenExchange') }} | ||
| {% if is_incremental() %} | ||
| WHERE | ||
| {{ incremental_predicate('evt_block_time') }} | ||
| {% endif %} |
There was a problem hiding this comment.
this doesn't fully follow the current logic we have for Curve on other chains.
Is the deployment on base different then on other chains?
There was a problem hiding this comment.
I am thinking this too.
This implementation covers stable pool type swaps.
github-actions
bot
added
WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
[...]
quick links for more information: