Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tokens_sonic_erc20 #7414

Merged
merged 9 commits into from
Jan 7, 2025
Merged

update tokens_sonic_erc20 #7414

merged 9 commits into from
Jan 7, 2025

Conversation

viniabussafi
Copy link
Contributor

@viniabussafi viniabussafi commented Jan 3, 2025 •
edited
Loading

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

updating sonic tokens based on tokens registered on Beets' V2 and V3 vault: https://dune.com/queries/4516961

quick links for more information:

@github-actions github-actions bot added WIP work in progress dbt: tokens covers the Tokens dbt subproject labels Jan 3, 2025
@viniabussafi viniabussafi marked this pull request as ready for review January 3, 2025 18:15
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jan 3, 2025
@viniabussafi viniabussafi mentioned this pull request Jan 3, 2025
Merged
@jeff-dude jeff-dude self-assigned this Jan 3, 2025
@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR and removed ready-for-review this PR development is complete, please review labels Jan 3, 2025
@viniabussafi
Copy link
Contributor Author

viniabussafi commented Jan 7, 2025 •
edited
Loading

Hey @jeff-dude!

Received this update from the sonic team:

  1. https://coinpaprika.com/coin/s-sonic/
  2. https://coinpaprika.com/coin/ws-wrapped-sonic/
  3. https://coinpaprika.com/coin/scusd-sonic-usd/
  4. https://coinpaprika.com/coin/sceth-sonic-eth/
  5. https://coinpaprika.com/coin/sts-staked-sonic/

this should allow us to move forward with #7399

@viniabussafi viniabussafi mentioned this pull request Jan 7, 2025
Open
@jeff-dude
Copy link
Member

Hey @jeff-dude!

Received this update from the sonic team:

  1. https://coinpaprika.com/coin/s-sonic/
  2. https://coinpaprika.com/coin/ws-wrapped-sonic/
  3. https://coinpaprika.com/coin/scusd-sonic-usd/
  4. https://coinpaprika.com/coin/sceth-sonic-eth/
  5. https://coinpaprika.com/coin/sts-staked-sonic/

this should allow us to move forward with #7399

amazing! i was able to email them directly, and they acted fast. good to know.

looks like brush is no longer active though, should we remove that one?

@viniabussafi
Copy link
Contributor Author

should be good to go now!

jeff-dude
jeff-dude approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for helping out!

@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Jan 7, 2025
@jeff-dude jeff-dude merged commit d7ca7d3 into duneanalytics:main Jan 7, 2025
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeff-dude jeff-dude jeff-dude approved these changes

Assignees

@jeff-dude jeff-dude

Labels
dbt: tokens covers the Tokens dbt subproject ready-for-merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viniabussafi @jeff-dude