Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Variable::from_usize #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Variable::from_usize #9

wants to merge 2 commits into from

Conversation

dhardy
Copy link

@dhardy dhardy commented Sep 11, 2018

Rationale: I have a unique reproducible way of generating keys per variable; using that saves me from creating a Variable → key map.

src/lib.rs Show resolved Hide resolved
@schell
Copy link

schell commented Oct 16, 2019

Oh, look at that. You did!

@dhardy
Copy link
Author

dhardy commented Oct 16, 2019

Yes, I did. This crate appears unmaintained. For my use-case, I'll probably move kas away from Cassowary anyway because it is inefficient and hard to debug.

@schell
Copy link

schell commented Oct 16, 2019

What will you use instead? Are the inefficiencies unable to be overcome with some profiling?

@dhardy
Copy link
Author

dhardy commented Oct 17, 2019

I'm mostly done with replacement code for my case which isn't quite as flexible but good enough and a lot simpler overall. I'll link to it when I'm done.

Inefficiencies are mostly because of the number of allocations this lib does, I think. Haven't looked into it much and it may still be good enough.

@dhardy
Copy link
Author

dhardy commented Oct 17, 2019

What will you use instead?

My replacement code is mostly done now, and very specific to my use-case (widget placement). See:

The latter is the heart of this system: lots of code injected per widget (I am hoping this doesn't cause issues when scaling to complex UIs; it also needs adjustment to handle dynamic content).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants