Skip to content

Commit

Permalink
🔥 Stop failing the test if code coverage goes down
Browse files Browse the repository at this point in the history
We currently run tests and check code coverage in the same workflow,
and fail if the code coverage goes down. But our current coverage is fairly
limited (< 20%) so we have a lot of failures from changes to code that
currently does not have any tests.

Let's still check the code coverage, but disable the `fail_on_error` so it
doesn't mask errors in the tests. Once we improve coverage to cover more areas,
we can re-enable this.
  • Loading branch information
shankari committed Dec 21, 2024
1 parent 126ceb9 commit 242cf3b
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/code-coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,4 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: ./coverage/coverage-final.json
flags: unit
fail_ci_if_error: ${{ github.repository == 'e-mission/e-mission-phone' }}

0 comments on commit 242cf3b

Please sign in to comment.