Always show CDT Debug Preference Pages #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2024
The CDT Debug Activites was originally added when we had two distinct debuggers in CDT, the DSF one and the CDI one. To eliminate confusion the preferences for the respective debug infrastructures were only displayed if users actually ran such a debug session. Now with just one debug infrastructure, we should always display the preference pages. It also removes some confusion that some preference pages weren't visible until after you started the debug session. So for example, users couldn't turn on or off a bunch of default settings until after creating and launching a debug session. I have left the enableActivity call in GdbLaunchDelegate in case any extenders were hiding some of their UI behind that key. The only exception in the above is the View Performance preference page which was misplaced in the top level Run/Debug preference tree, even though it is CDT specific. That preference page has been re-parented to C/C++ -> Debug Fixes eclipse-cdt#972
jonahgraham
force-pushed
the
dsf-activity
branch
from
301f992 to
ae9747f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CDT Debug Activites was originally added when we had two distinct debuggers in CDT, the DSF one and the CDI one. To eliminate confusion the preferences for the respective debug infrastructures were only displayed if users actually ran such a debug session.
Now with just one debug infrastructure, we should always display the preference pages. It also removes some confusion that some preference pages weren't visible until after you started the debug session. So for example, users couldn't turn on or off a bunch of default settings until after creating and launching a debug session.
I have left the enableActivity call in GdbLaunchDelegate in case any extenders were hiding some of their UI behind that key.
The only exception in the above is the View Performance preference page which was misplaced in the top level Run/Debug preference tree, even though it is CDT specific. That preference page has been re-parented to C/C++ -> Debug
Fixes #972