[#942] GDBControl discards ILaunchConfiguration in its constructor #989
Conversation
…structor add protected final field to be available for successors adding final accessor method may break Embedded CDT
|
Interesting, why adding a field to a class considered as a major change |
There was a problem hiding this comment.
Interesting, why adding a field to a class considered as a major change
Error: [API ERROR] File GDBControl.java at line 117: The field org.eclipse.cdt.dsf.gdb.service.command.GDBControl.config has been added to a class (location: /work/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/command/GDBControl.java) Error: [API ERROR] File MANIFEST.MF at line 6: The major version should be incremented in version 7.2.0, since API breakage occurred since version 7.1.300 (location: /work/dsf-gdb/org.eclipse.cdt.dsf.gdb/META-INF/MANIFEST.MF)
So this change requires a major version bump as it is possibly breaking change. That is ok in principle for CDT 12 as that is a major version. But you have to decide whether CDT API consumers are likely to be affected negatively more or less than how you benefit from this change.
I am +0 on this change as on a quick examination of the open source and closed source extensions of GDBControl I don't actually see anyone who has their own field called config
Thank you for review @jonahgraham |
add protected final field to be available for successors
adding final accessor method may break Embedded CDT
Fixes #942