-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate more of the documentation with asciidoc and automate more #995
base: main
Are you sure you want to change the base?
Conversation
Some additional notes.
@jld01 When you contributed the adoc work you added to help.css. Did you manually craft that css yourself, or was it the result of running asciidoctor one time and then adding it to help.css? I will probably create a separate css for the adoc files so I can fix the above mentioned spacing issues, but looking into insights as to how you got to this stage |
@jonahgraham, I copied a minimal set of definitions from the default asciidoctor CSS into help.css as necessary. This was mainly for correct presentation of tables. My goal at that time was to ensure that the asciidoctor-generated pages had a similar look to the existing documentation. |
If I have understood correctly, the HTML files are generated as part of the PR checks so a contributor need not install Maven themselves. I can see the benefit for PR review purposes, but, to me, placing generated files under version control seems strange. Perhaps I will warm to the idea. If we do this, then we should make it very clear that contributors are not expected to update the HTML themselves. Perhaps a |
Overall, the generated HTML looks great, @jonahgraham. 👍 |
To me too - can we discuss more quickly at the meeting today if you are coming. I've added it to the agenda. |
I added a new helpadoc.css that is used only by asciidoc files, leaving the original help.css back to its original state. That gives me a place add the missing vertical spacing without breaking the existing html help like this https://github.com/jonahgraham/cdt/blob/2fed9cfc6032a50e4fbe9cc74d998bf7118762b4/doc/org.eclipse.cdt.doc.user/helpadoc.css#L6-L9 |
Actions from the call (#967) today that affect this:
|
As downloaded from https://fontawesome.com/v4/assets/font-awesome-4.7.0.zip Will be used in next commit to remove remote use of font awesome in asciidoctor: https://docs.asciidoctor.org/asciidoctor/latest/html-backend/local-font-awesome/
- Migrate all getting_started from html to adoc - Document (in README.md) notes on migrating html to adoc - Reorganize generation of adoc slightly so that - all directories can be generates at once - output suffix changed to htm so that migrated files exist at the same URL on help.eclipse.org - Add generation to the cleanliness checks to ensure that the html matches adoc - Manage the adoc headers with a script as that is a large section of copy-pasted code on each adoc file (see README + adoc-headers.txt) - Move maven version info to pluginManagement (consistency with other maven plug-ins) - New profile "asciidoc-auto-refresh" which will auto build the files as edited. Prerequisite of eclipse-cdt#992
@jld01 - I wanted to bring this to your attention. I added it in the latest commit and found that it is really helpful because it means regeneration is almost instant. See the updated docs readme for more details. |
exist at the same URL on help.eclipse.org
html matches adoc
of copy-pasted code on each adoc file (see README + adoc-headers.txt)
maven plug-ins)
files as edited.
Prerequisite of #992