Collab advanced new #250
Open
Collab advanced new #250
+38,856
−11,769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…u items (eclipse-glsp#20) This ensures that the order is stable and allows the server to control the order of elements in the command palette on the client. Resolves eclipse-glsp#19
…sp#26) In Sprotty layoutOptions can be AbstractLayoutOptions (pre-defined key-value pairs) or ModelLayoutOptions (a generic string to string/number/boolean map). To capture that behavior on the Java side we made the layout options generic but provide GLayoutOptions to capture the set of pre-defined key-value pairs.
* Enable handlers returning multiple actions to a client action This is in preparation for eclipse-glsp#6. * Let server handle the dirty state Resolves eclipse-glsp#6
This enables the handling of multiple routingpoints changes in one action. Similar to change bounds action
This avoids Eclipse issues with Java10. This also aligns the plugin configuration and the maven configuration (which uses Java 1.8 anyways)
- Introduce new helper class for easier configuration of multi bindings (add,remove,rebind) - Remove ActionProvider and bind Action classes directly via multi bind - Introduce InstanceRegistry (client side already has a similar concept) - Refactor ActionRegistry to make use of the new InstanceRegistry - Move multibinding default values into dedicated util class
* Bump checkstyle from 8.23 to 8.29 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.23 to 8.29. - [Release notes](https://github.com/checkstyle/checkstyle/releases) - [Commits](checkstyle/checkstyle@checkstyle-8.23...checkstyle-8.29) Signed-off-by: dependabot[bot] <[email protected]> * Update codestyle and fix checkstyle error - Update checkstyle.xml to be compatible to new newest checkstyle version - Update autogenerated copyright header to (c) 2020 - Improve copyright header regex to allow other contributors then "EclipseSource and others" - Also: Set mvn compiler level to Java 1.8 Co-authored-by: Tobias Ortmayr <[email protected]>
…clipse-glsp#43) * RequestMarkersHandler should also deal with lists containing the empty element like it does with undefined and empty lists Signed-off-by: Johannes Faltermeier <[email protected]>
The increased buffersize allows messages with a length up to 8MB which should be more than enough for most usescases
The tycho-ant-run task for creating the composite update site seems to break with Java17. Since this task is just creating the update site the Java version is not really relevant so for now we switch back to 11. Update jenkins file to trigger Java21 compatibility when on master merges.
Fix GModelDeleteOperationHandler by updating the collectDependents method. - Dont add child elements of elements that should be deleted to the dependent set. They will be deleted indirectly anyways because the parent container is deleted. - Correctly add incoming/outgoing edges to the dependet set instead of their targets/sources
Set ELK version to 0.8.1 in m2 build until eclipse-glsp/glsp#1213 is resolved.
Always execute post update queue even if there is no handler for the UpdateModelAction
- Ensure that the ActionDispatchers postUpdateQueue is also cleared after the inital `SetModelAction` - Change visibility of private members to protected for better extensibility - Ensuare that Request and Response actions are initialized with an empty string as request/response id. This is required because otherwise typechecks on the client might fail
Update type hints configuration for workflow example to make fork and join nodes not resizable => we have test cases for both resizable and non-resizable elements in the diagram
- Extract thread creation and initialization out of constructor Contributed on behalf of Axon Ivy AG
Update the NodeDocumentationNavigationTargetProvider to not rely on the tasks name which is currently unreliable (see eclipse-glsp/glsp#1351) and instead relies on the `text` property of the tasks label.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
How to test
Follow-ups
Changelog