Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(svg): parse opacity of empty/'none'/'transparent' color as 0 and add warning for development environment #1092

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(svg): parse opacity of empty/'none'/'transparent' color as 0 and add warning for development environment #1092

wants to merge 3 commits into from

Conversation

plainheart
Copy link
Collaborator

@plainheart plainheart commented Aug 2, 2024 •
edited
Loading

Reproduction Demo

Before After
image image

@plainheart plainheart force-pushed the fix/svg/transparent-color branch from 7f423d6 to df3b3f3 Compare August 2, 2024 07:01
@plainheart plainheart changed the title fix(svg): fix SVG rendering bug when gradient color stops includes 'transparent' color fix(svg): parse opacity of empty/'none'/'transparent' color as 0 and add warning for development environment Aug 2, 2024
Ovilia
Ovilia previously approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ovilia Ovilia Ovilia left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plainheart @Ovilia