[feat] export annotation set [Round 2] #2704
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ously used to import from main process without virtualDom
…the state root level. Now not specific to the search, search rely on this resourceCache just like import/export annotations routine
TODO: dispatch annotationQueue shift action across reader
main-process and broadcasted to every other browserWindow opened ANNOTATION_SHIFT_FROM_ANNOTATION_IMPORT_QUEUE need this mechanism
…our advice about this !
|
yes I would also use the HTML body as the DOM tree root to compute text position and quote. |
panaC
commented
Dec 18, 2024
|
Hello @danielweck, I let you review this PR for the import/export annotationSet part |
makeRefinable from apache-annotator TODO: need to define an heuristic of selector priority/importance
…note and do not create a duplicate note to the list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows :
For the CFI Selector : vivliostyle-cfi doesn't support CFI Range with the comma separator cf (only position supported)
This PR is on a blocking state as long as the CFI library issue is not resolved.
We leave the choice to use CFI for the moment
for the benefice to use a CssSelector refined by TextPositionSelector
Cf the spec made by Laurent : https://github.com/readium/annotations
I reintroduced the ProgressionSelector to keep this information across export/import in thorium annotation format. Progression is generated from the r2-navigator to chrome ui and not from the ui to the r2-navigator.