Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add sdn-check API endpoint #10

Merged
merged 12 commits into from
Oct 31, 2023
Merged

feat: Add sdn-check API endpoint #10

merged 12 commits into from
Oct 31, 2023

Conversation

julianajlk
Copy link
Member

@julianajlk julianajlk commented Oct 25, 2023 •
edited
Loading

REV-3625.

This PR:

  • Adds APITest base class.
  • Adds testing setup and adds testing packages.
  • Adds tests for SanctionsCheckView.
  • Adds SanctionsClient class and tests.
  • Updates settings with SDN related configs (URL, keys, etc).

This PR does not include: Sanctions fallback logic.

@julianajlk julianajlk force-pushed the julianajlk/REV-3625/sanctions-check-api branch 5 times, most recently from 7343237 to e76e157 Compare October 25, 2023 19:25
@julianajlk julianajlk force-pushed the julianajlk/REV-3625/sanctions-check-api branch from b9d2dba to def33c5 Compare October 25, 2023 19:34
@julianajlk julianajlk force-pushed the julianajlk/REV-3625/sanctions-check-api branch from cdba8ad to 29b6b54 Compare October 30, 2023 20:13
christopappas
christopappas approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@christopappas christopappas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mentioned you were adding a test in sdn_client_test.py. 👍 after that

@julianajlk julianajlk force-pushed the julianajlk/REV-3625/sanctions-check-api branch 2 times, most recently from c12afca to 4b58e68 Compare October 31, 2023 17:51
@julianajlk julianajlk force-pushed the julianajlk/REV-3625/sanctions-check-api branch from 4b58e68 to b8d3b02 Compare October 31, 2023 17:54
@julianajlk julianajlk changed the title feat: Add sanctions-check API feat: Add sdn-check API Oct 31, 2023
@julianajlk julianajlk changed the title feat: Add sdn-check API feat: Add sdn-check API endpoint Oct 31, 2023
@julianajlk julianajlk merged commit 0a34a55 into main Oct 31, 2023
6 checks passed
@julianajlk julianajlk deleted the julianajlk/REV-3625/sanctions-check-api branch October 31, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopappas christopappas christopappas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianajlk @christopappas