Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add more forgiving timeout duration for sdn backup #87

Merged
merged 3 commits into from
Dec 19, 2024
Merged

fix: add more forgiving timeout duration for sdn backup #87

merged 3 commits into from
Dec 19, 2024

Conversation

christopappas
Copy link
Contributor

Merge checklist:
Check off if complete or not applicable:

  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Post-merge:

@christopappas christopappas requested a review from a team as a code owner December 18, 2024 21:07
@github-actions GitHub Actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  sanctions/apps/core
  models.py
  views.py
  sanctions/apps/core/tests
  factories.py
  sanctions/apps/sanctions
  models.py
  sanctions/apps/sanctions/management/commands
  populate_sdn_fallback_data_and_metadata.py
  sanctions/apps/sanctions/tests
  factories.py
Project Total  

This report was generated by python-coverage-comment-action

@christopappas christopappas merged commit d00ba77 into main Dec 19, 2024
6 checks passed
@christopappas christopappas deleted the cpappas/timeout_values branch December 19, 2024 19:20
shafqatfarhan
shafqatfarhan reviewed Dec 19, 2024
View reviewed changes
Copy link
Member

@shafqatfarhan shafqatfarhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shafqatfarhan shafqatfarhan shafqatfarhan left review comments

@julianajlk julianajlk julianajlk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christopappas @julianajlk @shafqatfarhan