-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and upload binary wheels in CI #36
Conversation
Looks pretty good! |
Building wheels is super slow. I think it's better to only run them on tagged commits and possibly when manually triggering the workflow. |
That's true, but it does provide some value: For every change the binaries are built and tested on every platform. |
I prefer fast CI, so please change it to run on tags and workflow_dispatch. |
@eerimoq I updated the workflows: the wheels will be built and uploaded when you publish a new release on GitHub. |
.github/workflows/release.yml
Outdated
|
||
on: | ||
release: | ||
types: [ published ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean? How do I trigger this workflow? I usually want to publish to PyPI on all tags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the solution from here
Hopefully that works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try it out. I'll merge!
src
foldercibuildwheel
to build binary wheelsversion.py