Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and upload binary wheels in CI #36

Merged
merged 19 commits into from
Oct 18, 2023

Conversation

zariiii9003
Copy link
Contributor

  • move project configuration from setup.py to pyproject.toml
  • set minimum supported python version to 3.7
  • move source code to src folder
  • use cibuildwheel to build binary wheels
  • remove version.py

@eerimoq
Copy link
Owner

eerimoq commented Oct 9, 2023

Looks pretty good!

@eerimoq
Copy link
Owner

eerimoq commented Oct 9, 2023

Building wheels is super slow. I think it's better to only run them on tagged commits and possibly when manually triggering the workflow.

@zariiii9003
Copy link
Contributor Author

Building wheels is super slow. I think it's better to only run them on tagged commits and possibly when manually triggering the workflow.

That's true, but it does provide some value: For every change the binaries are built and tested on every platform.
But i can change it if you like.

@eerimoq
Copy link
Owner

eerimoq commented Oct 11, 2023

I prefer fast CI, so please change it to run on tags and workflow_dispatch.

@zariiii9003
Copy link
Contributor Author

@eerimoq I updated the workflows: the wheels will be built and uploaded when you publish a new release on GitHub.
I also run the tests through pytest for prettier output:
image


on:
release:
types: [ published ]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean? How do I trigger this workflow? I usually want to publish to PyPI on all tags.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misread what you said earlier to be honest. So this workflow would be triggered whenever you publish a new release here on GitHub. But i just noticed, that you don't do that 😄
image

I'll change that back so it is triggered by tags.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the solution from here
Hopefully that works.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it out. I'll merge!

@eerimoq eerimoq merged commit 6eb57b4 into eerimoq:master Oct 18, 2023
6 checks passed
@zariiii9003 zariiii9003 deleted the cibuildwheel branch August 13, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants