Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop python<=3.7 support #42

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

drop python<=3.7 support #42

wants to merge 4 commits into from

Conversation

kloczek
Copy link

@kloczek kloczek commented Sep 24, 2024

According to https://endoflife.date/python python 3.7 has been EOSed 27 Jun 2023.
Filter all code over pyupgracde --py38-plus.

According to https://endoflife.date/python python 3.7 has been
EOSed 27 Jun 2023.
Filter all code over `pyupgracde --py38-plus`.

Signed-off-by: Tomasz Kłoczko <[email protected]>
Signed-off-by: Tomasz Kłoczko <[email protected]>
@eerimoq
Copy link
Owner

eerimoq commented Sep 24, 2024

I'm sure many systems will continue to use older versions. You sure this is a good idea?

@kloczek
Copy link
Author

kloczek commented Sep 25, 2024

As long as in new version will have requires-python = ">=3.8" whoever will try to download something for 3.7 still will be able download prev version with requires-python = ">=3.7".
If it will be any critical change which should be backported to 3.7 still on got tag with version supporting 3.7 will be possible to create branch and release JFDI new release.
This approach allows have clean code on master.

@kloczek
Copy link
Author

kloczek commented Sep 25, 2024

Do you want me to remove 3.7 from CI as well in this PR? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants