Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getting-started.asciidoc #8434

Merged
merged 3 commits into from
Dec 21, 2024
Merged

Update getting-started.asciidoc #8434

merged 3 commits into from
Dec 21, 2024

Conversation

predogma
Copy link

The connection should be using the cloud id and API key, not the cloud endpoint.

The image unfortunately will need to be updated to as it obfuscates the cloud id and highlights the endpoint copy.

Sample Screenshot
Screenshot 2024-12-20 at 9 51 28 AM

This would be consistent with our docs here
https://www.elastic.co/guide/en/elasticsearch/client/net-api/current/connecting.html#cloud-deployment

Which states always use the cloud id, for our Elastic Cloud Hosted deployments to connect.

predogma and others added 2 commits December 20, 2024 09:48
The connection should be using the cloud id and API key, not the cloud endpoint.

The image unfortunately will need to be updated to as it obfuscates the cloud id and highlights the endpoint copy.

This would be consistent with our docs here
https://www.elastic.co/guide/en/elasticsearch/client/net-api/current/connecting.html#cloud-deployment

Which states always use the cloud id, for our Elastic Cloud Hosted deployments to connect.
@marciw
Copy link
Contributor

marciw commented Dec 21, 2024

Thanks! I pushed a commit that fixes capitalization and adds the corrected image. I also borrowed the API key phrasing from the Python client docs for now.

PS: ideally this would target main rather than 8.17... but because I'm planning other improvements soon, I can just bring these changes along at that point. But FYI for future PRs :)

Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with edits

cc @flobernd

@marciw marciw merged commit 907eb2b into 8.17 Dec 21, 2024
21 checks passed
@marciw marciw deleted the predogma-patch-1 branch December 21, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants