Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visual Refresh] Add behindText vis color tokens #8253

Open
wants to merge 1 commit into
base: eui-theme/borealis
Choose a base branch
from
Open

[Visual Refresh] Add behindText vis color tokens #8253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/eui-theme-borealis/src/variables/colors/_colors_vis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,17 @@ export const colorVis: _EuiThemeVisColors = {
euiColorVis8: euiPaletteColorBlind.euiColorVis8.graphic,
euiColorVis9: euiPaletteColorBlind.euiColorVis9.graphic,

euiColorVisBehindText0: euiPaletteColorBlind.euiColorVis0.graphic,
euiColorVisBehindText1: euiPaletteColorBlind.euiColorVis1.graphic,
euiColorVisBehindText2: euiPaletteColorBlind.euiColorVis2.graphic,
euiColorVisBehindText3: euiPaletteColorBlind.euiColorVis3.graphic,
euiColorVisBehindText4: euiPaletteColorBlind.euiColorVis4.graphic,
euiColorVisBehindText5: euiPaletteColorBlind.euiColorVis5.graphic,
euiColorVisBehindText6: euiPaletteColorBlind.euiColorVis6.graphic,
euiColorVisBehindText7: euiPaletteColorBlind.euiColorVis7.graphic,
euiColorVisBehindText8: euiPaletteColorBlind.euiColorVis8.graphic,
euiColorVisBehindText9: euiPaletteColorBlind.euiColorVis9.graphic,

euiColorVisAsTextLight0: SEMANTIC_COLORS.accentSecondary100,
euiColorVisAsTextLight1: SEMANTIC_COLORS.primary100,
euiColorVisAsTextLight2: SEMANTIC_COLORS.accent100,
Expand Down
21 changes: 21 additions & 0 deletions packages/eui-theme-common/src/global_styling/variables/colors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,27 @@ export type _EuiThemeVisColors = {
euiColorVis8: string;
euiColorVis9: string;

/* deprecated - temp token; used only during theme migration */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking suggestion: How about we use the JSDoc @deprecated annotation for a strikethrough highlighting?

euiColorVisBehindText0: string;
/* deprecated - temp token; used only during theme migration */
euiColorVisBehindText1: string;
/* deprecated - temp token; used only during theme migration */
euiColorVisBehindText2: string;
/* deprecated - temp token; used only during theme migration */
euiColorVisBehindText3: string;
/* deprecated - temp token; used only during theme migration */
euiColorVisBehindText4: string;
/* deprecated - temp token; used only during theme migration */
euiColorVisBehindText5: string;
/* deprecated - temp token; used only during theme migration */
euiColorVisBehindText6: string;
/* deprecated - temp token; used only during theme migration */
euiColorVisBehindText7: string;
/* deprecated - temp token; used only during theme migration */
euiColorVisBehindText8: string;
/* deprecated - temp token; used only during theme migration */
euiColorVisBehindText9: string;

euiColorVisAsTextLight0: string;
euiColorVisAsTextLight1: string;
euiColorVisAsTextLight2: string;
Expand Down
11 changes: 11 additions & 0 deletions packages/eui/src/themes/amsterdam/global_styling/variables/_colors_vis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,17 @@ export const colorVis: _EuiThemeVisColors = {
euiColorVis8: euiPaletteColorBlind.euiColorVis8.graphic,
euiColorVis9: euiPaletteColorBlind.euiColorVis9.graphic,

euiColorVisBehindText0: '#6dccb1',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking suggestion: I understand that this is temporary but for better discoverability, consistency and clarity, can we add them in packages/eui/src/themes/amsterdam/global_styling/variables/_colors_vis.ts and use as ☝🏻 instead of hard-coding here? We could copy-paste them from packages/eui/src/themes/amsterdam/global_styling/variables/_colors_vis.scss.

We could also add a comment above them, similar to temp token; used only during theme migration.

euiColorVisBehindText1: '#79aad9',
euiColorVisBehindText2: '#ee789d',
euiColorVisBehindText3: '#a987d1',
euiColorVisBehindText4: '#e4a6c7',
euiColorVisBehindText5: '#f1d86f',
euiColorVisBehindText6: '#d2c0a0',
euiColorVisBehindText7: '#f5a35c',
euiColorVisBehindText8: '#c47c6c',
euiColorVisBehindText9: '#ff7e62',

euiColorVisAsTextLight0: '#006BB4',
euiColorVisAsTextLight1: '#017D73',
euiColorVisAsTextLight2: '#F5A700',
Expand Down