Merge pull request #36 from elchemy/code-quality

Code quality and links creation

lib/elm/platform.ex

@@ -12,7 +12,7 @@ defmodule Elm.Platform do
   @callback docs(Package.t) :: {:ok, list(Docs.Module.t)} | :error
   @callback search() :: {:ok, list(Searchable.t)} | :error
 
-  @latest_version Version.create(0, 19, 0)
+  @latest_version Version.create(0, 18, 0)
 
   @spec latest_version() :: Version.t
   def latest_version() do

lib/elm/platform/local_19.ex

@@ -6,18 +6,14 @@ defmodule Elm.Platform.Local19 do
   alias Elm.Version
   require Logger
 
-  @elm_version_minor 18
-  @elm_version "0.#{@elm_version_minor}.0"
-  @elm_json if @elm_version_minor == 19, do: "elm.json", else: "elm-package.json"
-
   @spec setup(Path.t()) :: {:ok, Project.t()} | :error
   def setup(root) do
     with :ok <- elm_init(root) do
       File.mkdir_p!(Path.join(root, "src"))
       project_json = read_project!(root)
 
       project = %Project{
-        elm_version: Version.create(0, @elm_version_minor, 0),
+        elm_version: Version.create(0, 19, 0),
         dependencies:
           project_json
           |> Map.get("dependencies", %{})
@@ -65,7 +61,7 @@ defmodule Elm.Platform.Local19 do
         File.mkdir_p!(Path.join(root, Path.dirname(entry)))
         File.write!(Path.join(root, entry), source)
 
-        binary = Application.app_dir(:ellie, "priv/bin/#{@elm_version}/elm")
+        binary = Application.app_dir(:ellie, "priv/bin/0.19.0/elm")
 
         args = [
           "--num",
@@ -105,7 +101,7 @@ defmodule Elm.Platform.Local19 do
 
   @spec format(String.t()) :: {:ok, String.t()} | :error
   def format(code) do
-    binary = Application.app_dir(:ellie, "priv/bin/#{@elm_version}/elm-format")
+    binary = Application.app_dir(:ellie, "priv/bin/0.19.0/elm-format")
     args = ["--stdin"]
     options = [in: code, out: :string, err: :string]
     result = Porcelain.exec(binary, args, options)
@@ -122,7 +118,7 @@ defmodule Elm.Platform.Local19 do
   # Helpers
 
   defp install_transitive_deps(root) do
-    binary = Application.app_dir(:ellie, "priv/bin/#{@elm_version}/elm")
+    binary = Application.app_dir(:ellie, "priv/bin/0.19.0/elm")
     args = ["--num", "1", binary, "make", "--report", "json"]
     options = [dir: root, out: :string, err: :string]
     result = Porcelain.exec("sysconfcpus", args, options)
@@ -137,7 +133,7 @@ defmodule Elm.Platform.Local19 do
           {:ok, :missing_required, name} ->
             original_elm_json =
               root
-              |> Path.join("#{@elm_json}.original")
+              |> Path.join("elm.json.original")
               |> File.read!()
               |> Poison.decode!()
 
@@ -240,23 +236,23 @@ defmodule Elm.Platform.Local19 do
   end
 
   defp elm_init(root) do
-    binary = Application.app_dir(:ellie, "priv/bin/#{@elm_version}/elm")
+    binary = Application.app_dir(:ellie, "priv/bin/0.19.0/elm")
     args = ["init"]
     options = [out: :string, err: :string, dir: root, in: "Y"]
     result = Porcelain.exec(binary, args, options)
     Logger.info("elm init\nexit: #{inspect(result)}\n")
 
     case result do
       %Porcelain.Result{status: 0} ->
-        case File.cp(Path.join(root, "#{@elm_json}"), Path.join(root, "#{@elm_json}.original")) do
+        case File.cp(Path.join(root, "elm.json"), Path.join(root, "elm.json.original")) do
           :ok ->
             :ok
 
           {:error, reason} ->
             Sentry.capture_message("elm init filesystem error",
               extra: %{
                 reason: reason,
-                elm_version: "#{@elm_version}"
+                elm_version: "0.19.0"
               }
             )
 
@@ -269,15 +265,15 @@ defmodule Elm.Platform.Local19 do
             stderr: result.err,
             stdout: result.out,
             status: result.status,
-            elm_version: "#{@elm_version}"
+            elm_version: "0.19.0"
           }
         )
 
         {:error, "init exited with code #{other}"}
 
       {:error, reason} ->
         Sentry.capture_message("elm init startup error",
-          extra: %{reason: reason, elm_version: "#{@elm_version}"}
+          extra: %{reason: reason, elm_version: "0.19.0"}
         )
 
         {:error, reason}
@@ -303,21 +299,21 @@ defmodule Elm.Platform.Local19 do
 
   defp read_project!(root) do
     root
-    |> Path.join("#{@elm_json}")
+    |> Path.join("elm.json")
     |> File.read!()
     |> Poison.decode!()
   end
 
   defp write_project!(project_json, root) do
     root
-    |> Path.join("#{@elm_json}")
+    |> Path.join("elm.json")
     |> File.write!(Poison.encode!(project_json))
   end
 
   defp default_project() do
     %{
       "type" => "application",
-      "elm-version" => "#{@elm_version}",
+      "elm-version" => "0.19.0",
       "source-directories" => ["src"],
       "dependencies" => %{
         "direct" => %{},