Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch app-builder-bin to node-module-collector to get all production node modules #8571

Open
wants to merge 118 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 110 commits
Commits
Show all changes
118 commits
Select commit Hold shift + click to select a range
8a34240
switch app-builder-bin to node-module-collector
Oct 4, 2024
f438899
fix ut
Oct 4, 2024
8523bfd
fix ut
Oct 4, 2024
5748dff
fix ut
Oct 4, 2024
150f031
delete ut
Oct 4, 2024
3c38a9e
fix ut
Oct 4, 2024
4e10883
fix ut
Oct 4, 2024
4ea2d53
fix ut
Oct 4, 2024
257b603
update ut
Oct 4, 2024
601bef9
update node modules collector
Oct 4, 2024
2b051a0
fix ut
Oct 4, 2024
b0ef651
update gitinore
Oct 4, 2024
c9c4071
update
Oct 4, 2024
352f08e
update yarn.lock
Oct 4, 2024
f7d91c6
update gitinogre
Oct 4, 2024
2453a15
fix ut
Oct 4, 2024
6823a87
update
Oct 4, 2024
aafd1be
fix ut
Oct 4, 2024
59aa878
fix ut
beyondkmp Oct 4, 2024
c571825
fix ut
Oct 4, 2024
24dbf44
use detect
Oct 5, 2024
1b8cc02
format code
Oct 5, 2024
98021d1
format code
Oct 5, 2024
5bff81b
fix ut
Oct 5, 2024
6da8b0a
fix ut
Oct 5, 2024
69e827a
update to 1.1.4
Oct 5, 2024
accaf6a
fix others submodule filter
beyondkmp Oct 6, 2024
fdb9dd0
add ut
Oct 6, 2024
4f0d78a
format code
Oct 6, 2024
14efc3a
format code
Oct 6, 2024
aca68c2
fix ut
Oct 6, 2024
8b1e1e2
format code
Oct 6, 2024
8bf110d
fix ut
Oct 6, 2024
32d6156
fix ut
Oct 6, 2024
a22668e
add excludeNodMoules
Oct 6, 2024
40df716
fix ut
Oct 6, 2024
5a2e5c5
fix ut
Oct 6, 2024
9d363a8
fix ut
Oct 6, 2024
ceef74c
fix ut
Oct 6, 2024
861f234
add ut
Oct 6, 2024
e2c7981
fix ut
Oct 6, 2024
e39e6d8
add ut
Oct 6, 2024
127857d
Merge branch 'master' into nodeModulesCollector
Oct 6, 2024
97cdc2d
Merge branch 'excludeNodemoudles' into nodeModulesCollector
Oct 6, 2024
e053855
revert some changes
Oct 6, 2024
2a968f9
delete the obsolete snapshot
Oct 6, 2024
56a9d1e
Merge branch 'master' into nodeModulesCollector
Oct 7, 2024
0a31869
madd node-module-collector
beyondkmp Oct 8, 2024
09cdecd
update lock file
beyondkmp Oct 8, 2024
1227c00
format code
beyondkmp Oct 8, 2024
600958c
format code
beyondkmp Oct 8, 2024
ce21b41
format code
beyondkmp Oct 8, 2024
42bafe1
format code
beyondkmp Oct 8, 2024
f30f7a4
format code
beyondkmp Oct 8, 2024
6956efc
format code
beyondkmp Oct 8, 2024
29c5d01
fix comments
beyondkmp Oct 9, 2024
81db133
fix ut
beyondkmp Oct 9, 2024
fcbe203
update ut
beyondkmp Oct 9, 2024
b6b7540
fix ut
beyondkmp Oct 9, 2024
8715743
fix ut
beyondkmp Oct 9, 2024
94af9fb
format code
beyondkmp Oct 9, 2024
aca36e1
format code
beyondkmp Oct 9, 2024
ce2dfb5
update ignore
beyondkmp Oct 9, 2024
b2b72bf
update ignore
beyondkmp Oct 9, 2024
38ba984
update yarn.lock
beyondkmp Oct 9, 2024
d6377ff
update yarn.lock
beyondkmp Oct 9, 2024
4d42331
update yarn.lock
beyondkmp Oct 9, 2024
6c2469d
fix ut
beyondkmp Oct 9, 2024
34e8f2e
format code
beyondkmp Oct 10, 2024
cb9a8e3
Merge branch 'master' into nodeModulesCollectorNew
beyondkmp Oct 10, 2024
d691e60
delete filter
beyondkmp Oct 10, 2024
37e467f
format code
beyondkmp Oct 10, 2024
b9c85e0
add ut
beyondkmp Oct 10, 2024
f3cb216
fix ut
beyondkmp Oct 10, 2024
7bdeb9d
format code
beyondkmp Oct 10, 2024
7b58b83
fix ut
beyondkmp Oct 10, 2024
b0db426
udpate snap
beyondkmp Oct 10, 2024
43e0c96
add ut
beyondkmp Oct 10, 2024
5368fa3
update snapshot
beyondkmp Oct 10, 2024
4d6f786
add ut
beyondkmp Oct 10, 2024
fb5e01e
add comments
beyondkmp Oct 10, 2024
1039ed0
update node version
beyondkmp Oct 10, 2024
9d06f58
Merge branch 'master' into nodeModulesCollectorNew
beyondkmp Oct 10, 2024
4804709
Merge branch 'master' into nodeModulesCollectorNew
beyondkmp Oct 10, 2024
8f582c1
Merge branch 'master' into nodeModulesCollectorNew
beyondkmp Oct 11, 2024
457c2e5
fix ut
beyondkmp Oct 11, 2024
d2e2de7
add ut for hoist
beyondkmp Oct 12, 2024
e6f3b59
add comments
beyondkmp Oct 12, 2024
7c37814
Merge branch 'master' into nodeModulesCollectorNew
beyondkmp Oct 12, 2024
b57ffc8
fix ut
beyondkmp Oct 12, 2024
72dc559
format code
beyondkmp Oct 12, 2024
7d37e19
format code
beyondkmp Oct 12, 2024
d50c66d
update readme
beyondkmp Oct 12, 2024
b4d620d
Merge branch 'master' into nodeModulesCollectorNew
beyondkmp Oct 14, 2024
6a1ef9b
Merge branch 'master' into nodeModulesCollectorNew
beyondkmp Oct 15, 2024
c42b429
fix lint
beyondkmp Oct 15, 2024
e01bc6f
fix npm list error
beyondkmp Oct 15, 2024
875af7c
format code
beyondkmp Oct 15, 2024
61fb295
format code
beyondkmp Oct 15, 2024
f85abe1
format code
beyondkmp Oct 15, 2024
fe15c95
fix ut
beyondkmp Oct 15, 2024
3899607
fix ut
beyondkmp Oct 15, 2024
be11d50
format code
beyondkmp Oct 15, 2024
0dd953f
fix ut
beyondkmp Oct 15, 2024
6d919e9
fix ut
beyondkmp Oct 15, 2024
641eb43
fix yarn error
beyondkmp Oct 16, 2024
f844771
Merge branch 'master' into nodeModulesCollectorNew
beyondkmp Oct 16, 2024
1ea244d
fix comments
beyondkmp Oct 24, 2024
2dee313
fix https://github.com/npm/npm/issues/17624
beyondkmp Oct 24, 2024
0595127
Merge branch 'master' into nodeModulesCollectorNew
beyondkmp Oct 24, 2024
1f58fd4
delete log.filepath
beyondkmp Oct 29, 2024
d02d442
Merge branch 'master' into nodeModulesCollectorNew
beyondkmp Oct 30, 2024
5d56096
Merge branch 'master' into nodeModulesCollectorNew
beyondkmp Nov 5, 2024
5b52161
Merge branch 'master' into nodeModulesCollectorNew
beyondkmp Nov 6, 2024
cb7181f
Merge branch 'master' into nodeModulesCollectorNew
beyondkmp Nov 11, 2024
9e8986b
Merge branch 'master' into nodeModulesCollectorNew
beyondkmp Nov 20, 2024
aabc01b
Merge branch 'master' into nodeModulesCollectorNew
beyondkmp Dec 4, 2024
4601c7f
fix ut
beyondkmp Dec 4, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/pnpm/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ runs:
- name: Setup node
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4
with:
node-version: '18'
node-version: '20'
cache: 'pnpm'

- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/pretest/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ runs:
- name: Setup node
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4
with:
node-version: '18'
node-version: '20'
cache: 'pnpm'

- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
fail-fast: false
matrix:
testFiles:
- ArtifactPublisherTest,BuildTest,ExtraBuildTest,RepoSlugTest,binDownloadTest,configurationValidationTest,filenameUtilTest,filesTest,globTest,ignoreTest,macroExpanderTest,mainEntryTest,urlUtilTest,extraMetadataTest,linuxArchiveTest,linuxPackagerTest,HoistedNodeModuleTest,MemoLazyTest
- ArtifactPublisherTest,BuildTest,ExtraBuildTest,RepoSlugTest,binDownloadTest,configurationValidationTest,filenameUtilTest,filesTest,globTest,ignoreTest,macroExpanderTest,mainEntryTest,urlUtilTest,extraMetadataTest,linuxArchiveTest,linuxPackagerTest,HoistedNodeModuleTest,MemoLazyTest,HoistTest
- snapTest,debTest,fpmTest,protonTest
steps:
- name: Checkout code repository
Expand Down
15 changes: 0 additions & 15 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,21 +100,6 @@ See the full documentation on [electron.build](https://www.electron.build).

`yarn add electron-builder --dev`

### Note for PNPM

In order to use with `pnpm`, you'll need to adjust your `.npmrc` to use any one the following approaches in order for your dependencies to be bundled correctly (ref: [#6389](https://github.com/electron-userland/electron-builder/issues/6289#issuecomment-1042620422)):
```
node-linker=hoisted
```
```
public-hoist-pattern=*
```
```
shamefully-hoist=true
```

Note: Setting shamefully-hoist to true is the same as setting public-hoist-pattern to *.

### Note for Yarn 3

Yarn 3 use PnP by default, but electron-builder still need node-modules(ref: [yarnpkg/berry#4804](https://github.com/yarnpkg/berry/issues/4804#issuecomment-1234407305)). Add configuration in the `.yarnrc.yaml` as follows:
mmaietta marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
Loading
Loading