-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to libpeas-2 #1501
base: master
Are you sure you want to change the base?
Migrate to libpeas-2 #1501
Conversation
6bb4cc6
to
b8ef69a
Compare
Thanks for the work!
Can we send this upstream? |
Probably, it should just be a matter of deb packaging but it won't solve the Flatpak issue I ran up against. I am not convinced libpeas-2 is the way to go - it provides a lot of stuff we don't need like loading JavaScript plugins which has to be included in the Flatpak (unless there are some compile options I haven't found yet). I am going to try to produce another PR removing libpeas altogether for comparison. |
Libpeas may provide small advantages in code organization, but as far as I am aware the main point is to allow third-party plugins written in other languages and separately packaged in other projects to be used (they just need to be installed into the right directory). |
I don't see a problem in allowing to load Javascript plugins, but okay. |
Its not a problem, just unnecessary. Need to identify functional advantages of libpeas to justify the extra dependencies. |
@danirabbit Will it be possible to ship libpeas-2 version 2.0.5 in elementary 8 if it is not in Ubuntu 24.04? |
The main advantage of keeping the libpeas dependency for now, especially if we can lose the need for the |
Hmm - as far as I can make out,, even Gnome is not using |
@leonardo-lemos Thanks! I forgot to check the CI file as everything worked locally. |
Fixes #1498
.vapi
for libpeas-2 for now as is not currently supplied by the libpeas-2-dev package available (2.0.0) but it is supplied by 2.0.5 which is published in Ubuntu 24.10 (Oracular) and later. Not sure how to get it into elementary8 which is based on Ubuntu 24.04LTS..deb
Used a ListBox bound to the Peas.Engine list_model for the Preferences Dialog, but as the model does not change while the ListBox in use may be simpler to construct and sort it manually.