Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run/fix UI and Server linting #3258

Closed
wants to merge 1 commit into from
Closed

Conversation

lresende
Copy link
Member

What changes were proposed in this pull request?

Run/fix UI and Server linting

How was this pull request tested?

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@lresende lresende mentioned this pull request Dec 21, 2024
7 tasks
@lresende lresende added this to the 4.0.0 milestone Dec 24, 2024
Signed-off-by: Luciano Resende <[email protected]>
@shalberd
Copy link
Contributor

shalberd commented Dec 26, 2024

typescript stuff / coding conventions and linting, looking sensible to me.
@caponetto FYI, since I heard you are often involved in frontend stuff :-)

@caponetto
Copy link
Contributor

IMO it'd be better to apply these changes after #3201 gets merged, otherwise we will likely end up with more conflicts to resolve on that PR.

@lresende
Copy link
Member Author

Let's ignore this for now, I believe I have updated my local env and some new dependencies are being installed and causing this, for now let me close this.

@lresende lresende closed this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants