Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove read_entry_data method from class ComponentCatalogConnector (#3141) #3266

Merged
merged 3 commits into from
Jan 1, 2025

Conversation

lresende
Copy link
Member

What changes were proposed in this pull request?

Revert "Remove read_entry_data method from class ComponentCatalogConnector (#3141)

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

…talogConnector (elyra-ai#3141)"

This reverts commit a60ae72.
This is breaking the build as it seems its not complete yet.

Signed-off-by: Luciano Resende <[email protected]>
@lresende lresende closed this Dec 31, 2024
@lresende lresende reopened this Dec 31, 2024
Signed-off-by: Luciano Resende <[email protected]>
Signed-off-by: Luciano Resende <[email protected]>
@lresende
Copy link
Member Author

lresende commented Jan 1, 2025

Reverting and creating issue to reapply these changes #3268

@lresende lresende merged commit 6eef65b into elyra-ai:main Jan 1, 2025
38 checks passed
@lresende lresende deleted the revert-3141 branch January 1, 2025 02:47
@caponetto
Copy link
Contributor

@lresende FYI the issue with mistune has been resolved and released
See jupyter/nbconvert#2198

(@lresende @shalberd could you please invite me to Elyra Slack? You have my email)

@shalberd
Copy link
Contributor

shalberd commented Jan 3, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants