Add v0.11 migrations page #147
Conversation
| } | ||
| ``` | ||
|
|
||
| 2. Add [ember-engines-router-service](https://github.com/villander/ember-engines-router-service) to `dependencies` |
There was a problem hiding this comment.
maybe we should mention this is optional and only needed if you do external routing/linktoexternal ?
There was a problem hiding this comment.
I don’t think so. It should be mandatory given it’s part of the engine RFC. We should make router service for engines accessible as we have for normal ember apps
There was a problem hiding this comment.
regardless of the rfc, this change was not to complete the rfc it was to keep support for the current usecases and remove engines from a state of upgrade blocker
we should by no means force more packages on people than they need
future engines will have this baked in as an optional thing they can use
the issue here is it's not in the main repo and an outside package
There was a problem hiding this comment.
I know it wasn't the intention to complete the RFC, but it ended up completing the RFC. That being said, there's a long wait for this feature/support. So that's not something up to us, but it was something promised since 2016 by the core team and all RFC's should be implemented unless there's another RFC that relates the old one. So I agree with @SergeAstapov here and IMO it must be merged. The second step would be to make ember-engines-router-service part of the ember-engines addon to complete the RFC
| transition methods of Controller and Route were removed. | ||
| Follow [deprecation guide](https://ember-engines.com/docs/deprecations#-transition-methods-of-controller-and-route) for migration examples. | ||
|
|
||
| 4. Droped support for query param only router service transitions until it's resolved upstream https://github.com/villander/ember-engines-router-service/issues/74. |
There was a problem hiding this comment.
| 4. Droped support for query param only router service transitions until it's resolved upstream https://github.com/villander/ember-engines-router-service/issues/74. | |
| 4. Dropped support for query param only router service transitions until it's resolved upstream https://github.com/villander/ember-engines-router-service/issues/74. |
Documents changes made in ember-engines/ember-engines#855