Switch to es5 getters #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kennethlarsen 👍 Should be good to go after the conflict is resolved. Then we can merge the PR on the Guides as well. cc/ @locks @acorncom |
|
@kennethlarsen still interested in getting this merged in, would you have time to resolve the conflicts here? |
|
@acorncom Sure! There were some concerns or doubts in the learning team whether they actually wanted this or not. But if that's resolved I'll happily resolve the conflicts. |
|
@acorncom Looks like yarn is breaking CI. Not sure what to do here |
sivakumar-kailasam
requested changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue reference: emberjs/guides#2303