Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in config option to purge all queues on startup. #61

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add in config option to purge all queues on startup. #61

wants to merge 6 commits into from

Conversation

knappe
Copy link
Member

@knappe knappe commented Nov 1, 2016

No description provided.

@knappe knappe force-pushed the Add-Queue-Purging-Config-Option branch from f9292bc to 62bf3d9 Compare November 2, 2016 15:57
@randy-girard randy-girard force-pushed the Add-Queue-Purging-Config-Option branch from 3b825c6 to 6f5fc81 Compare June 13, 2017 14:44
@randy-girard
Copy link
Contributor

@knappe Updated the spec for this

knappe
knappe commented Jun 13, 2017
View reviewed changes
Copy link
Member Author

@knappe knappe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit and what I think is now an unnecessary method. Because I'm the author, I can't request these changes.

spec/adapters/rabbit_mq/worker/worker_spec.rb Outdated
:type => "dummy.spec"
}
}))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra newline

spec/dummy/consumers/spec_consumer.rb Outdated
class SpecConsumer
include Emque::Consuming.consumer

def test(message)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this method now.

@knappe
Copy link
Member Author

knappe commented Jun 13, 2017

@randy-girard Awesome, thanks for pushing this along! 🎉

@randy-girard
Copy link
Contributor

@knappe Addressed your nits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knappe @randy-girard