Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include term Attribute in Violations and Warnings Output #2045

Closed
wants to merge 1 commit into from
Closed

Include term Attribute in Violations and Warnings Output #2045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion internal/output/output.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,12 @@ func keepSomeMetadata(results []evaluator.Result) {
}
}

// keepSomeMetadataSingle retains only specific metadata keys in the result.
// **Updated to include "term" by default as per the acceptance criteria.**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this line.

func keepSomeMetadataSingle(result evaluator.Result) {
for key := range result.Metadata {
if key == "code" || key == "effective_on" {
// Retain "code", "effective_on", and "term" keys
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment doesn't seem very helpful. Let's drop it.

if key == "code" || key == "effective_on" || key == "term" {
continue
}
delete(result.Metadata, key)
Expand Down
Loading