Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Terraform Provider Docs for Alibaba Integration #821

Merged
merged 6 commits into from
Nov 23, 2024

Conversation

d-bhola
Copy link
Contributor

@d-bhola d-bhola commented Nov 22, 2024

No description provided.

@d-bhola d-bhola requested a review from a team as a code owner November 22, 2024 16:06
@d-bhola d-bhola changed the title CXF-99867: Add Terraform Provider Docs for Alibaba Integration feat: Add Terraform Provider Docs for Alibaba Integration Nov 22, 2024
@d-bhola d-bhola changed the title feat: Add Terraform Provider Docs for Alibaba Integration feat: add Terraform Provider Docs for Alibaba Integration Nov 22, 2024
@d-bhola d-bhola changed the title feat: add Terraform Provider Docs for Alibaba Integration feat: Add Terraform Provider Docs for Alibaba Integration Nov 22, 2024
Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes requested. Thanks for adding this!

templates/resources/fabric_connection.md.tmpl Outdated Show resolved Hide resolved
templates/resources/fabric_connection.md.tmpl Outdated Show resolved Hide resolved
templates/resources/fabric_connection.md.tmpl Outdated Show resolved Hide resolved
Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made an assumption about the PR and was incorrect. Please see comment.

Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change requested.


Create the connection using the Equinix Terraform provider. Then manually accept the connection request in the Alibaba Portal for the created physical connection.

**Note:** The `connection_name` must follow either one of these patterns:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't perfectly clear. We don't need any of the details related to connection name. That's only for when you're integrating with alicloud via the data source

Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ship it.

@d-bhola d-bhola merged commit f59e5d5 into main Nov 23, 2024
7 of 9 checks passed
@d-bhola d-bhola deleted the CXF-99867-alibaba branch November 23, 2024 01:34
Copy link

github-actions bot commented Dec 9, 2024

This PR is included in version 3.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants