Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redudant clauses in local parse/3 #162

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

ariel-anieli
Copy link

Fix for #70; issue solved by @l3kn.
@ferd, could you have a look?

@ariel-anieli
Copy link
Author

ariel-anieli commented Dec 9, 2023

1> [Year,X,Month,X,Day,Hour,$:,Min,$:,Sec,$., Ms | PAM] = [2014,himBHs,8,himBHs,28,23,$:,39,$:,10,$.,1].
[2014,45,8,45,28,23,58,39,58,10,46,1]
2> [Month,X,Day,X,Year,Hour,$:,Min,$:,Sec,$., Ms | PAM] = [8,himBHs,28,himBHs,2014,23,$:,39,$:,10,$.,1].
[8,45,28,45,2014,23,58,39,58,10,46,1]
3> [Day,X,Month,X,Year,Hour,$:,Min,$:,Sec,$., Ms | PAM] = [28,himBHs,8,himBHs,2014,23,$:,39,$:,10,$.,1].
[28,45,8,45,2014,23,58,39,58,10,46,1]
4> PAM.
[]

Copy link
Collaborator

@ferd ferd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised ?is_meridien/1 considers an empty list to be valid, but at this point it's better to remove the dead code than change the matching one.

@ferd ferd merged commit 4d5811d into erlware:master Dec 10, 2023
6 checks passed
ariel-anieli added a commit to ariel-anieli/erlware_commons that referenced this pull request Dec 10, 2023
@ariel-anieli ariel-anieli deleted the issue-70-redundant-parse branch January 8, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants