-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Member tests in parallel #19035
base: main
Are you sure you want to change the base?
Run Member tests in parallel #19035
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AwesomePatrol The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @AwesomePatrol. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 24 files with indirect coverage changes @@ Coverage Diff @@
## main #19035 +/- ##
==========================================
+ Coverage 68.73% 68.85% +0.11%
==========================================
Files 420 420
Lines 35623 35625 +2
==========================================
+ Hits 24486 24529 +43
+ Misses 9702 9674 -28
+ Partials 1435 1422 -13 Continue to review full report in Codecov by Sentry.
|
ee67c51
to
bda32aa
Compare
This comment was marked as outdated.
This comment was marked as outdated.
bda32aa
to
cbeb76e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
cbeb76e
to
879c0f0
Compare
Introduce port allocator and remove unused MemberNumber. On my local machine it brings down execution time from 5m to 32s. Issue: etcd-io#18983 Signed-off-by: Aleksander Mistewicz <[email protected]>
Signed-off-by: Aleksander Mistewicz <[email protected]>
879c0f0
to
2febbd8
Compare
/retest |
Signed-off-by: Aleksander Mistewicz <[email protected]>
@AwesomePatrol: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
In addition to this, have you considered using paralleltest ? |
On my local machine it brings down execution time from 5 minutes to 32s.
I added a port allocator which allocates ports in 11000-19000 range.
Issue: #18983