refactor: loading spinner configurable tag #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rwd
commented
Dec 19, 2024
•
rwd
commented
- give the loading spinner a configurable root element tag, defaulting to div
- prevent the loading spinner elements rendering at all until its delay has elapsed, to help with CLS on not-too-slow pages/components
- remove all wrapping div, b-container, b-row and b-col elements from around LoadingSpinner in components that use it, and combine any classes from those onto the LoadingSpinner element itself
|
Preview deployment: https://pr-2530.portal-js.dev.eanadev.org/ |
LeoniePeters
approved these changes
Dec 19, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.