Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

variable length quantity #311

Merged
merged 21 commits into from
Dec 2, 2024
Merged

variable length quantity #311

merged 21 commits into from
Dec 2, 2024

Conversation

Falilah
Copy link
Contributor

@Falilah Falilah commented Dec 1, 2024

Closes #247

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2024

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

0xNeshi
0xNeshi requested changes Dec 1, 2024
View reviewed changes
Copy link
Contributor

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work!

exercises/practice/variable-length-quantity/Scarb.toml Outdated Show resolved Hide resolved
exercises/practice/variable-length-quantity/.meta/example.cairo Outdated Show resolved Hide resolved
exercises/practice/variable-length-quantity/.meta/example.cairo Outdated Show resolved Hide resolved
exercises/practice/variable-length-quantity/.meta/example.cairo Outdated Show resolved Hide resolved
config.json Outdated Show resolved Hide resolved
exercises/practice/variable-length-quantity/.meta/example.cairo Outdated Show resolved Hide resolved
@Falilah Falilah requested a review from 0xNeshi December 1, 2024 21:46
0xNeshi
0xNeshi approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@0xNeshi 0xNeshi added x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:rep/large Large amount of reputation x:action/create Work on something from scratch x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises) labels Dec 2, 2024
@0xNeshi 0xNeshi merged commit b754ae2 into exercism:main Dec 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xNeshi 0xNeshi 0xNeshi approved these changes

Assignees
No one assigned
Labels
x:action/create Work on something from scratch x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises) x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Practice Exercise: variable-length-quantity
2 participants
@Falilah @0xNeshi