Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tests of Palindrome Product exercise to sync with the Problem-Specification repo #2872

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jagdish-15
Copy link
Contributor

pull request


Reviewer Resources:

Track Policies

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@jagdish-15
Copy link
Contributor Author

Hello @kahgoh,

This update adds a single test to sync with the problem-specifications repository. I believe marking it as [no important files changed] should be appropriate, but I’d appreciate your thoughts on this.

@jagdish-15
Copy link
Contributor Author

The java-test-runner is failing the test. Could this be because the reference solution doesn't pass the newly added tests? I believe that might be the case, but please let me know your thoughts.

@kahgoh
Copy link
Member

kahgoh commented Nov 19, 2024

Yeah, looks like the reference implementation needs updating. It isn't super easy to see, but the CI logs contains the following:

Checking palindrome-products exercise...
palindrome-products: example solution did not pass the tests

@jagdish-15
Copy link
Contributor Author

Sure, will do it as soon as possible.

@jagdish-15
Copy link
Contributor Author

Hello @kahgoh,

After a thorough review, I realized there was an oversight in the newly added tests. I'm happy to report that the issue has been fixed after identifying the mistake through debugging. My apologies for any confusion caused!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants