Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rational Numbers: Add error test case to expreal property #2213

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Rational Numbers: Add error test case to expreal property #2213

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b06325e
Rational Numbers: add error test case to expreal property
natanaelsirqueira Mar 1, 2023
1f67186
Add better error message
natanaelsirqueira Mar 1, 2023
aa68104
Review fixes
natanaelsirqueira Mar 2, 2023
51304e8
Use reduced rational number as input
natanaelsirqueira Mar 2, 2023
9a2b1cb
Add case for when the rational number has not been reduced
natanaelsirqueira Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions exercises/rational-numbers/canonical-data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,28 @@
"r": [0, 1]
},
"expected": 1.0
},
{
"uuid": "da137f1c-fc94-4035-9813-94f5152a1102",
"description": "Raise a negative real number to a rational number with an even numerator",
"property": "expreal",
"input": {
"x": -1,
"r": [2, 2]
},
"expected": 1.0
natanaelsirqueira marked this conversation as resolved.
Show resolved Hide resolved
},
{
"uuid": "f3734f78-91b2-4e59-905e-8c61dbf34f39",
"description": "Fails with a negative real number if the numerator of the rational number is odd",
natanaelsirqueira marked this conversation as resolved.
Show resolved Hide resolved
"property": "expreal",
"input": {
"x": -1,
"r": [1, 2]
},
"expected": {
"error": "impossible to raise a negative base to an exponent with an odd numerator"
}
}
]
},
Expand Down