-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Only lint changelog in Node 16 #2147
Conversation
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
Size Change: -1.78 kB (0%) Total Size: 55.5 MB
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2147 +/- ##
========================================
Coverage 54.20% 54.20%
========================================
Files 509 509
Lines 18657 18657
Branches 3736 3927 +191
========================================
Hits 10112 10112
+ Misses 8524 7856 -668
- Partials 21 689 +668 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good for now, but in my opinion, we should try to make it work with Node 18 because Node 16 is no longer supported. I believe we should also add support for Node 20 run our test workflows on Node 16,18,20, and drop support for Node 14. WDYT?
Feel free to merge this as it is. We can figure it out later on.
Ok, I think that it broke in Node |
WDYT about #2153? |
Superseded by #2153 |
Why
lint-changelog
tends to sometimes fail on Node 18 (see this). I don't want to debug why.How
After noticing
scripts/tsconfig.json
mentions "node16", I figured maybe scripts are supposed to only run on Node 16. Adjusted matrix and job spec.eas-cli/scripts/tsconfig.json
Lines 4 to 5 in 04a8b08
Test Plan
I mean, it's linting changelog…