Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-11071][eas-json][eas-cli] bump dependencies and fix errors/warnings #2176

Merged
merged 7 commits into from
Jan 17, 2024
Merged

[ENG-11071][eas-json][eas-cli] bump dependencies and fix errors/warnings #2176

merged 7 commits into from
Jan 17, 2024

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Jan 12, 2024 •
edited
Loading

Why

Bump dependencies

How

Bump dependencies. Fix errors caused by bumping. Fix jest warnings, make jest configs use TS.

Test Plan

Tests + run some commands manually

@szdziedzic szdziedzic changed the title bump dependencies and fix errors/warnings [eas-json][eas-cli] bump dependencies and fix errors/warnings Jan 12, 2024
@szdziedzic szdziedzic force-pushed the @szdziedzic/bump-dependencies branch from 3a0ea33 to 7feef3d Compare January 12, 2024 09:55
@szdziedzic
Copy link
Member Author

/changelog-entry chore Update eas-cli and @expo/eas-json dependencies

@codecov Codecov
Copy link

codecov bot commented Jan 12, 2024 •
edited
Loading

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (ccc8d5a) 54.24% compared to head (db41438) 54.11%.

Files Patch % Lines
...rc/devices/actions/create/developerPortalMethod.ts 0.00% 4 Missing ⚠️
packages/eas-cli/src/metadata/errors.ts 33.34% 4 Missing ⚠️
.../credentials/android/AndroidCredentialsProvider.ts 33.34% 2 Missing ⚠️
...kages/eas-cli/src/credentials/manager/ManageIos.ts 71.43% 2 Missing ⚠️
packages/eas-cli/src/commands/config.ts 0.00% 1 Missing ⚠️
packages/eas-cli/src/credentials/errors.ts 0.00% 1 Missing ⚠️
packages/eas-cli/src/vcs/clients/git.ts 0.00% 1 Missing ⚠️
packages/eas-json/src/accessor.ts 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2176      +/-   ##
==========================================
- Coverage   54.24%   54.11%   -0.13%     
==========================================
  Files         511      516       +5     
  Lines       18756    18815      +59     
  Branches     3758     3771      +13     
==========================================
+ Hits        10173    10179       +6     
- Misses       8562     8615      +53     
  Partials       21       21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic
Copy link
Member Author

Oh well...

After the eslint, prettier, and eslint rules update I was seeing errors due to incorrect order of imports and missing whitespaces between import groups. I ran the yarn lint --fix command to fix these but it edited 160 files making it slightly harder to review. From what I see all of these are import reorders or adding whitespaces between imports.

This is the commit that edited these files 2b0a99f

I hope it isn't a big problem when it comes to reviewing this PR.

@szdziedzic
Copy link
Member Author

https://github.com/expo/eas-cli/actions/runs/7501659185/job/20422721322?pr=2176 - it fails because it checkouts main version of the codebase and runs it's against the lerna version from this branch, which is newer and incompatible with useWorkspaces option used in lerna.json option on main branch. I think we can safely ignore it.

@szdziedzic szdziedzic changed the title [eas-json][eas-cli] bump dependencies and fix errors/warnings [ENG-11071][eas-json][eas-cli] bump dependencies and fix errors/warnings Jan 12, 2024
@linear Linear
Copy link

linear bot commented Jan 12, 2024

ENG-11071 Bump dependencies in all EAS Build related repos

@szdziedzic szdziedzic marked this pull request as ready for review January 16, 2024 10:07
radoslawkrzemien
radoslawkrzemien approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@radoslawkrzemien radoslawkrzemien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice 🚀

packages/eas-cli/src/build/ios/__tests__/version-test.ts Outdated
@@ -62,7 +62,7 @@ describe(evaluateTemplateString, () => {
// bare workflow
describe(bumpVersionAsync, () => {
beforeEach(() => {
getPbxproj.mockImplementation(() => ({} as any));
getPbxproj.mockImplementation(() => ({}) as any);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

({}) is a bit weird

@szdziedzic szdziedzic force-pushed the @szdziedzic/bump-dependencies branch from 2b0a99f to ec4c49a Compare January 17, 2024 10:03
@github-actions GitHub Actions
Copy link

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic merged commit ab8115b into main Jan 17, 2024
9 of 10 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/bump-dependencies branch January 17, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radoslawkrzemien radoslawkrzemien radoslawkrzemien approved these changes

@wschurman wschurman wschurman approved these changes

@sjchmiela sjchmiela Awaiting requested review from sjchmiela

@khamilowicz khamilowicz Awaiting requested review from khamilowicz

@byCedric byCedric Awaiting requested review from byCedric

@EvanBacon EvanBacon Awaiting requested review from EvanBacon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szdziedzic @wschurman @radoslawkrzemien