-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] Add flag to emit build meta #2451
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few changes (noted inline). Main one is to remove the term "build" from this since, in the context of EAS CLI, "build" means something very different (EAS build).
I'm definitely all for re-adding this back in though.
97cc87e
to
43ab7de
Compare
@wschurman I have applied all the suggested changes, please let me know if I missed anything |
applied change suggestions
43ab7de
to
5cc6578
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more changes, otherwise looks good. I'll merge after the changes are made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. happy to add this feature back behind a flag :)
fixed internal flag name Co-authored-by: Will Schurman <[email protected]>
@wschurman I have committed your changes and replaced all the occurrences of the old variable with the new one. There shouldn't be any Thank you @quinlanj for reviewing! |
Why
Currently Bugsnag doesn't support automatic source map upload after running eas update so I made a script that makes a manual submission after bundling and submitting an update. The script is relying on
eas-update-metadata.json
to obtain the bundle ids.I am currently using [email protected] and the update script is working well, but I have realised that this feature was removed with the v7 release thus preventing me from updating to a newer version of
eas-cli
.How
This feature was introduced in #2158 and removed in #2187, so I have reverted the changes and put the feature behind the
--emit-build-meta--emit-metadata
flag rather than having it aways on so nothing will change for people that don't really need it.Test Plan
I have tested with my update pipeline script and it works as expected.
eas update --emit-metadata
and in the dist folder there should beeas-update-metadata.json
with the following shape:eas update
without the--emit-metadata
flag--skip-bundler
flag is set a warning will notify the user that--emit-metadata
will be ignored because not applicable