Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] improve eas env:pull logging #2720

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Nov 22, 2024

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@szdziedzic szdziedzic marked this pull request as ready for review November 22, 2024 14:26
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @khamilowicz, @sjchmiela

Generated by CodeMention

Copy link

github-actions bot commented Nov 22, 2024

Size Change: -2.2 kB (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB -2.2 kB (0%)

compressed-size-action

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.74%. Comparing base (bd2d39f) to head (04f147a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/env/pull.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2720   +/-   ##
=======================================
  Coverage   52.74%   52.74%           
=======================================
  Files         580      580           
  Lines       22283    22283           
  Branches     4358     4358           
=======================================
  Hits        11751    11751           
  Misses      10496    10496           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@szdziedzic szdziedzic force-pushed the 11-22-_eas-cli_improve_eas_env_pull_logging branch from b53c224 to 04f147a Compare November 22, 2024 14:55
Copy link

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic merged commit 8da6adf into main Nov 22, 2024
7 checks passed
@szdziedzic szdziedzic deleted the 11-22-_eas-cli_improve_eas_env_pull_logging branch November 22, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants