Skip to content

Commit

Permalink
fixup: remove invalid todos
Browse files Browse the repository at this point in the history
  • Loading branch information
expressvpn-tom-l committed Oct 17, 2023
1 parent 413c784 commit 19b0db0
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions src/he/pmtud.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ he_return_code_t he_internal_pmtud_send_probe(he_conn_t *conn, uint16_t probe_mt
uint16_t payload_size = probe_mtu + sizeof(he_msg_data_t) - sizeof(he_msg_ping_t);
probe->length = payload_size;

// TODO: fill payload with random data

conn->pmtud_probe_count++;
conn->pmtud_probing_size = probe_mtu;

Expand Down Expand Up @@ -109,10 +107,6 @@ he_return_code_t he_internal_pmtud_handle_probe_ack(he_conn_t *conn, uint16_t pr
he_internal_pmtud_send_probe(conn, conn->pmtud_probing_size);
}
break;
case HE_PMTUD_STATE_SEARCH_COMPLETE:
// Effective PMTU probe acked
// TODO: start a timer to recheck
break;
case HE_PMTUD_STATE_ERROR:
// Base PMTU probe acked, enter Searching state now
return he_internal_pmtud_base_confirmed(conn);
Expand All @@ -137,7 +131,6 @@ he_return_code_t he_internal_pmtud_handle_probe_timeout(he_conn_t *conn) {
switch(conn->pmtud_state) {
case HE_PMTUD_STATE_BASE:
// Unable to confirm the base PMTU, entering error state.
// TODO: we could try confirming a smaller BASE_PMTU
return he_internal_pmtud_confirm_base_failed(conn);
case HE_PMTUD_STATE_SEARCHING:
if(conn->pmtud_is_using_big_step) {
Expand Down Expand Up @@ -235,7 +228,6 @@ he_return_code_t he_internal_pmtud_confirm_base_failed(he_conn_t *conn) {
// Change state
he_internal_pmtud_change_state(conn, HE_PMTUD_STATE_ERROR);

// TODO: try continue probe with MIN_PLPMTU here
// TODO: recheck base pmtu periodically
conn->pmtud_probe_count = 0;

Expand Down

0 comments on commit 19b0db0

Please sign in to comment.