fixup: check return code of he_internal_pmtud_start_base_probing

expressvpn · Oct 18, 2023 · 68e2738 · 68e2738
1 parent f6a1266
commit 68e2738
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/he/conn.c b/src/he/conn.c
@@ -1196,9 +1196,7 @@ he_return_code_t he_conn_start_pmtu_discovery(he_conn_t *conn) {
   }
 
   // Enter Base state
-  he_internal_pmtud_start_base_probing(conn);
-
-  return HE_SUCCESS;
+  return he_internal_pmtud_start_base_probing(conn);
 }
 
 uint16_t he_conn_get_effective_pmtu(he_conn_t *conn) {

diff --git a/src/he/pmtud.c b/src/he/pmtud.c
@@ -169,6 +169,9 @@ he_return_code_t he_internal_pmtud_start_base_probing(he_conn_t *conn) {
     case HE_PMTUD_STATE_SEARCH_COMPLETE:
       // Valid states
       break;
+    case HE_PMTUD_STATE_BASE:
+      // Already in base state, do nothing
+      return HE_SUCCESS;
     default:
       // Invalid states
       return HE_ERR_INVALID_CONN_STATE;