Merge pull request #126 from expressvpn/fix-compiler-warnings

Fix multiple compiler warnings in tests
expressvpn · Oct 13, 2023 · 91129f9 · 91129f9
2 parents 17fc115 + 0522e3b
commit 91129f9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/test/he/test_conn.c b/test/he/test_conn.c
@@ -1,4 +1,4 @@
-/* *
+/**
  * Lightway Core
  * Copyright (C) 2021 Express VPN International Ltd.
  *
@@ -575,7 +575,7 @@ void test_send_keepalive_error_when_not_connected(void) {
 }
 
 // Stub function for writing a he_msg_ping_t to wolfssl
-static int wolfSSL_write_ping_stub(WOLFSSL *ssl, const void *data, int sz) {
+static int wolfSSL_write_ping_stub(WOLFSSL *ssl, const void *data, int sz, int num_calls) {
   TEST_ASSERT_EQUAL_PTR(conn.wolf_ssl, ssl);
   TEST_ASSERT_NOT_NULL(data);
   TEST_ASSERT_GREATER_OR_EQUAL(sizeof(he_msg_ping_t), sz);

diff --git a/test/he/test_msg_handlers.c b/test/he/test_msg_handlers.c
@@ -184,7 +184,7 @@ void test_msg_handler_pong(void) {
 
   he_msg_pong_t *pong = (he_msg_pong_t *)empty_data;
   pong->id = htons(42);
-  ret = he_handle_msg_pong(conn, pong, sizeof(he_msg_pong_t));
+  ret = he_handle_msg_pong(conn, (uint8_t *)pong, sizeof(he_msg_pong_t));
   TEST_ASSERT_EQUAL(HE_SUCCESS, ret);
 }
 
@@ -193,7 +193,7 @@ void test_msg_handler_pong_mismatch_id(void) {
 
   he_msg_pong_t *pong = (he_msg_pong_t *)empty_data;
   pong->id = htons(999);
-  ret = he_handle_msg_pong(conn, pong, sizeof(he_msg_pong_t));
+  ret = he_handle_msg_pong(conn, (uint8_t *)pong, sizeof(he_msg_pong_t));
   TEST_ASSERT_EQUAL(HE_SUCCESS, ret);
 }
 

diff --git a/test/he/test_ssl_ctx.c b/test/he/test_ssl_ctx.c
@@ -1,4 +1,4 @@
-/* *
+/**
  * Lightway Core
  * Copyright (C) 2021 Express VPN International Ltd.
  *
@@ -949,7 +949,8 @@ void test_he_ssl_ctx_is_ca_set_set_ctx_null(void) {
 }
 
 void test_he_ssl_ctx_set_server_cert_key_files_ctx_null(void) {
-  he_return_code_t res = he_ssl_ctx_set_server_cert_key_files(NULL, fake_cert, fake_cert);
+  he_return_code_t res =
+      he_ssl_ctx_set_server_cert_key_files(NULL, (const char *)fake_cert, (const char *)fake_cert);
   TEST_ASSERT_EQUAL(HE_ERR_NULL_POINTER, res);
 }