This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
Primitive inlining of custom fonts #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The support is done by parsing all font-face urls, fetching them as binary files, and inlining them as data uri (https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/Data_URIs) Note: it's very rudimentary and fragile. But it works when applied correctly, and I thought it could be useful for more people. exupero#24
anvaka
commented
Dec 3, 2016
| @@ -151,8 +272,6 @@ | |||
| clone.setAttribute('transform', clone.getAttribute('transform').replace(/translate\(.*?\)/, '')); | |||
|
|
|||
| var svg = document.createElementNS('http://www.w3.org/2000/svg','svg') | |||
| svg.appendChild(clone) | |||
There was a problem hiding this comment.
not sure why this is removed.
There was a problem hiding this comment.
That logic is only hit if you pass a node within an SVG rather than the SVG itself. It probably shouldn't be removed for the changes you've made.
There was a problem hiding this comment.
This looks like the only blocker to merging this in.
There was a problem hiding this comment.
I guess I pressed a wrong button in vim and the code was removed in mistake :).
Added it back.
|
This looks great! Thanks for tackling this. Your approach to add rudimentary support makes a good starting point for further refinements. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw a few bugs for the custom fonts inlining and one PR: #29
In this change I'm loading fonts asynchronously. The custom fonts need way more care than I have time now, but I was hoping this could be a good start.
You can find working demo here: https://anvaka.github.io/saveSvgAsPng/ - if you don't immediately see custom fonts loaded - try clicking on "Save as PNG" button - it should work there.
There are plenty things to do to make this fix production quality, and I left a few TODOs there. Hope someone will find it useful.