right-click-enabler: Allow activation of the right click action by keyboard

[tyrylu]

This allows for example, selecting the audio output device for visually
impaired.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[f4exb]

Can you please explain what it is supposed to do?

[tyrylu]

yYou mean that the commit message is not descriptive enough (even with an example of a fixed use-case)?
It solves the bug where the right click action is only activatable using the mouse, and that's bad, because, well, not everyone uses the mouse.

[srcejon]

yYou mean that the commit message is not descriptive enough (even with an example of a fixed use-case)? It solves the bug where the right click action is only activatable using the mouse, and that's bad, because, well, not everyone uses the mouse.

Looks like it allows use of the menu key or shift-f10 to emulate right mouse click on the focused widget. Shift-f10 is the standard windows keyboard shortcut to display a context menu.

[f4exb]

@tyrylu It just misses which keys are to be used at least in the comments

Thanks for the explanation @srcejon I tried in Linux but mousing over a right click enabled button and pressing Shift+F10 just does nothing. Is it a Windows only feature?

[srcejon]

Thanks for the explanation @srcejon I tried in Linux but mousing over a right click enabled button and pressing Shift+F10 just does nothing. Is it a Windows only feature?

I think you need to give the widget focus by tabbing to it. Cursor can be anywhere on screen.

However, shift-F10 doesn't work for me on Windows either. The menu key does work though.

Oddly, no KeyPress event gets to the rightclickhandler for shift-F10.

[f4exb]

Oddly, no KeyPress event gets to the rightclickhandler for shift-F10.

That's what I noticed also by putting there a debug message.

[f4exb]

My mistake... it seems it works (on Linux) by tabbing to the concerned widget and not by mousing over.
Well so I think we can validate this.

[srcejon]

The problem with shift-F10 on Windows, it's that Qt automatically converts it in to a QEvent::ContextMenu - which we are currently filtering, because that was giving us pop-up menus when tap-and-hold is used to emulate right-clicks. So I probably need to revisit that.