Skip to content
cpp-linter

Use unified flat filling function #535

Sign in to view logs

Use unified flat filling function

Use unified flat filling function #535

Triggered via pull request November 29, 2023 18:23
@JNechaevskyJNechaevsky
opened #1116
fillflat
Status Success
Total duration 1m 30s
Artifacts –

cpp-linter.yml

on: pull_request
Matrix: cpp-linter
Fit to window
Zoom out
Zoom in

Annotations

1 error, 10 warnings, and 7 notices
/src/doom/m_background.h:55:8 [clang-diagnostic-error]: src/doom/m_background.h#L55
unknown type name 'byte'
/src/doom/f_finale.c:275:10 [cppcoreguidelines-init-variables]: src/doom/f_finale.c#L275
variable 'w' is not initialized
/src/doom/f_finale.c:275:10 [readability-identifier-length]: src/doom/f_finale.c#L275
variable name 'w' is too short, expected at least 3 characters
/src/doom/m_background.h:55:13 [cppcoreguidelines-avoid-non-const-global-variables]: src/doom/m_background.h#L55
variable 'crispness_background' is non-const and globally accessible, consider making it const
/src/doom/st_stuff.c:410:7 [cppcoreguidelines-init-variables]: src/doom/st_stuff.c#L410
variable 'x' is not initialized
/src/doom/st_stuff.c:410:7 [readability-identifier-length]: src/doom/st_stuff.c#L410
variable name 'x' is too short, expected at least 3 characters
/src/v_video.c:955:18 [bugprone-easily-swappable-parameters]: src/v_video.c#L955
4 adjacent parameters of 'V_FillFlat' of similar type ('int') are easily swapped by mistake
/src/v_video.c:956:24 [readability-non-const-parameter]: src/v_video.c#L956
pointer parameter 'src' can be pointer to const
/src/v_video.c:958:5 [readability-isolate-declaration]: src/v_video.c#L958
multiple declarations in a single statement reduces readability
/src/v_video.c:958:9 [cppcoreguidelines-init-variables]: src/v_video.c#L958
variable 'x' is not initialized
/src/v_video.c:958:9 [readability-identifier-length]: src/v_video.c#L958
variable name 'x' is too short, expected at least 3 characters
Run clang-format on src/doom/f_finale.c: src/doom/f_finale.c#L1
File src/doom/f_finale.c does not conform to Custom style guidelines. (lines 275, 287)
Run clang-format on src/doom/m_background.h: src/doom/m_background.h#L1
File src/doom/m_background.h does not conform to Custom style guidelines. (lines 55)
Run clang-format on src/doom/m_menu.c: src/doom/m_menu.c#L1
File src/doom/m_menu.c does not conform to Custom style guidelines. (lines 1439, 1446, 1450)
Run clang-format on src/doom/r_draw.c: src/doom/r_draw.c#L1
File src/doom/r_draw.c does not conform to Custom style guidelines. (lines 1130)
Run clang-format on src/doom/st_stuff.c: src/doom/st_stuff.c#L1
File src/doom/st_stuff.c does not conform to Custom style guidelines. (lines 410, 418, 419)
Run clang-format on src/v_video.c: src/v_video.c#L1
File src/v_video.c does not conform to Custom style guidelines. (lines 955, 956)
Run clang-format on src/v_video.h: src/v_video.h#L1
File src/v_video.h does not conform to Custom style guidelines. (lines 91, 92)