Adding Crispy-Hud for Heretic #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raw Version of Crispy Hud
Alignment Keys and Armor in Fullscreen Hud
Update Comment
Expanding Screenblocks to 12.
Removal of unnecessary files.
Conservative Crispy Hud with moved jewels between Item and Ammo, height of widgets from the original hud.
Adjusted Jewels with original spacing to item
Update sb_bar.c to fix height of item selector
Cleanup comments and use non-transparent patch for item selector background.
Move Frags to be visible above health.
Moving Hud down by 10px
src/heretic/mn_menu.c
Outdated
| @@ -1125,7 +1125,7 @@ static void DrawOptionsMenu(void) | |||
|
|
|||
| static void DrawOptions2Menu(void) | |||
| { | |||
| DrawSlider(&Options2Menu, 1, 9, screenblocks - 3); | |||
| DrawSlider(&Options2Menu, 1, 9, (screenblocks < 12 ? screenblocks : 11) - 3); | |||
There was a problem hiding this comment.
I think we have a BETWEEN() macro for cases like this.
There was a problem hiding this comment.
The macro is now used in all three occasions.
src/heretic/sb_bar.c
Outdated
| @@ -1051,69 +1051,169 @@ void DrawInventoryBar(void) | |||
|
|
|||
| void DrawFullScreenStuff(void) | |||
| { | |||
| const char *patch; | |||
| const char *patch; | |||
There was a problem hiding this comment.
No unrelated white space changes, please.
Added "return" in crispy hud condition to keep indentation of original code intact.
fabiangreffrath
approved these changes
Nov 5, 2024
|
Next step: Crispy HUD for Hexen. Any takers? |
|
Thanks alot for bringing it in!
Not much of a Hexen player myself, but I will think about it. :) |
I made a suggestion in this issue, if you want to have a look: |
fabiangreffrath
pushed a commit
that referenced
this pull request
Nov 21, 2024
* Updated Crispy Hud Raw Version of Crispy Hud * Alignment Keys and Armor in Fullscreen Hud Alignment Keys and Armor in Fullscreen Hud * Update Comment Update Comment * Expanding Screenblocks to 12 Expanding Screenblocks to 12. * Removal of unnecessary files. Removal of unnecessary files. * Delete .project * Conservative Crispy Hud Conservative Crispy Hud with moved jewels between Item and Ammo, height of widgets from the original hud. * Adjusted Jewels Adjusted Jewels with original spacing to item * Update sb_bar.c to fix height of item selector Update sb_bar.c to fix height of item selector * Update sb_bar.c Cleanup comments and use non-transparent patch for item selector background. * Update sb_bar.c Move Frags to be visible above health. * Update sb_bar.c Moving Hud down by 10px * Fixing Findings for Pull-Request #1234 Fixing Findings for Pull-Request #1234 Crispy-Hud: #1234 * Restructuered DrawFullScreenStuff in sb_bar.c Added "return" in crispy hud condition to keep indentation of original code intact. * Adding rough Hexen crispy HUD First rough version of Hexen crispy HUD, without shifting widgets or considering widescreendelta. * Refine Hexen Crispy Hud Shift widgets to the left and right, make it align with aspect ratio, fixing indentation. * Shifting down Hexen Crispy Hud Shifting down Hexen Crispy Hud by 7px. Cleanup comments. * Refinement Hexen Crispy Hud Shifting up by 1px again, shifting item widget to the left instead of right. * Cirspy Hexen Hud - Inventory Bar Refinement Only draw health and ammo widget once the inventory is open. * Intersect check for Hexen Crispy Hud Display frags even when inventory open, adding intersect check between ManaPatch2 and Gem1. * Fix Hexen Crispy-Hud Item-Alignment Fix Hexen Crispy-Hud Item-Alignment to match standard HUD. * Align Heretic Crispy-HUD Bar with Hexen To be consistent with the Hexen Crispy-Hud: - Align height of Heretic HUD Item Selection Bar with vanilla fullscreen hud - Don't draw Ammo and Jewels when Gem2 overlaps with Jewels * Fixing PatchSELECTBOX Pos for Hexen Crispy-Hud Fixing PatchSELECTBOX Pos for Hexen Crispy-Hud by moving it 2px to the left to align with non-fullscreen standard hud.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
#656
Changes Summary: