Doom/Heretic: A11y Flickering - Correct Lightlevel in case of competing Strobe Thinkers #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed code. - Fixing flickering glitch when multiple strobe thinkers compete with the same sector-light. (see Heretic E1M6). - Removal of unrequired code in p_lights (reconstruction of maxlight in p_saveg).
.. other flashers are only spawned on setup-level and thus refer to the same sector-lightlevel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
None - I can open one if required.
Bug description
Observed behavior:
In Heretic E1M6 (Hall with Dragonclaw) I still noticed flickering, even though it was disabled in the accessibility menu. After having a look at the map in Doom-Builder, there are trigger based actions to spawn strobelights for 4 linedefs refering the same sectors (97, 116). When a strobelight is spawned, the current sector lightlevel is stored in the maxlight. Since those spawns are not done simultaneously (the player triggers them by walking around), the second to forth spawn will take an already modified lightlevel and the maxlight will thus be "incorrect". Afterwards, they overwrite the sector lightlevel with their maxlights and thus reintroduce a strobing effect.
Expected behavior:
rlightlevel should be the highest maxlight amongst those competitors, both after loading a savegame and during runtime.
Changes Summary